Fix build system integration and type annotations for rendezvous module #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add rendezvous.proto to Makefile PB variable for protobuf generation - Fix type annotations in errors.py and messages.py for mypy compatibility - Changes ensure proper protobuf file generation and type checking
3 tasks
sumanjeet0012
merged commit e461148
into
sumanjeet0012:feature/rendezvous
27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Rendezvous Module Build System Integration
Problem
The rendezvous module in PR libp2p#916 had build system integration issues that caused:
.pyistub filesSolution
rendezvous.prototo Makefile: Ensures protobuf files are generated during build processMessage.ResponseStatustoMessage.ResponseStatus.ValueTypefor mypy compatibilityFiles Changed
Makefile- Added rendezvous.proto to PB variablelibp2p/discovery/rendezvous/errors.py- Fixed type annotationslibp2p/discovery/rendezvous/messages.py- Fixed type annotationsImpact
This fix resolves the build system integration issues while maintaining the groundbreaking nature of the first complete rendezvous protocol implementation in the libp2p ecosystem.