Skip to content

Fix build system integration and type annotations for rendezvous module #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Fix build system integration and type annotations for rendezvous module #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ PB = libp2p/crypto/pb/crypto.proto \
libp2p/host/autonat/pb/autonat.proto \
libp2p/relay/circuit_v2/pb/circuit.proto \
libp2p/relay/circuit_v2/pb/dcutr.proto \
libp2p/kad_dht/pb/kademlia.proto
libp2p/kad_dht/pb/kademlia.proto \
libp2p/discovery/rendezvous/pb/rendezvous.proto

PY = $(PB:.proto=_pb2.py)
PYI = $(PB:.proto=_pb2.pyi)
Expand Down
4 changes: 2 additions & 2 deletions libp2p/discovery/rendezvous/errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
class RendezvousError(Exception):
"""Base exception for rendezvous protocol errors."""

def __init__(self, status: Message.ResponseStatus, message: str = ""):
def __init__(self, status: Message.ResponseStatus.ValueType, message: str = ""):
self.status = status
self.message = message
super().__init__(f"Rendezvous error {status}: {message}")
Expand Down Expand Up @@ -64,7 +64,7 @@ def __init__(self, message: str = "Service unavailable"):


def status_to_exception(
status: Message.ResponseStatus, message: str = ""
status: Message.ResponseStatus.ValueType, message: str = ""
) -> RendezvousError:
"""Convert a protobuf status to the appropriate exception."""
if status == Message.E_INVALID_NAMESPACE:
Expand Down
4 changes: 2 additions & 2 deletions libp2p/discovery/rendezvous/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def create_register_message(


def create_register_response_message(
status: Message.ResponseStatus, status_text: str = "", ttl: int = 0
status: Message.ResponseStatus.ValueType, status_text: str = "", ttl: int = 0
) -> Message:
"""Create a REGISTER_RESPONSE message."""
msg = Message()
Expand Down Expand Up @@ -64,7 +64,7 @@ def create_discover_message(
def create_discover_response_message(
registrations: list[Message.Register],
cookie: bytes = b"",
status: Message.ResponseStatus = Message.OK,
status: Message.ResponseStatus.ValueType = Message.OK,
status_text: str = "",
) -> Message:
"""Create a DISCOVER_RESPONSE message."""
Expand Down
Loading