-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: afterNavigate
callback not running after hydration when experimental async is enabled
#14644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d64ed3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
If this takes time, could there be a release where SvelteKit warns about using It seems to be a better approach then documenting in the Svelte docs. I have a private library that relies heavily on |
Fixes #14618
If svelte experimental async is enabled we need to wait a microtask(?) between mounting the app and running the
after_navigate_callbacks
, otherwise the script blocks run after running theafter_navigate_callbacks
(which means there are no callbacks yet).I'm not sure if adding a new test app is the right choice. Maybe we should run all tests once with and once without experimental async instead?
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits