-
-
Couldn't load subscription status.
- Fork 2.1k
fix: afterNavigate callback not running after hydration when experimental async is enabled
#14644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+79
−3
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c587356
test
PatrickG 466bf4e
fix
PatrickG f4ad4a6
changeset
PatrickG ef55453
lint
PatrickG 4fda011
format
PatrickG d6bb7de
move awaiting to fix snapshot restore after reload
PatrickG eb56912
Update .changeset/ten-rats-spend.md
PatrickG 8c91629
await initialize
PatrickG 6f47045
comment
PatrickG 7f77132
typo
PatrickG d64ed3d
comment
PatrickG 005d581
Merge branch 'main' into issue-14618
teemingc 3016395
Merge branch 'main' into issue-14618
dummdidumm 9e9a061
CI job with Svelte async experimental
dummdidumm de2c24f
fix lockfile
dummdidumm df84018
ugh
dummdidumm a3673c2
fucking hell how many package.jsons need this
dummdidumm b85d9c8
delete
dummdidumm 8533df0
skip failing test for now
dummdidumm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@sveltejs/kit': patch | ||
| --- | ||
|
|
||
| fix: `afterNavigate` callback not running after hydration when experimental async is enabled | ||
| fix: Snapshot `restore` method not called after reload when experimental async is enabled | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -181,6 +181,40 @@ jobs: | |
| retention-days: 3 | ||
| name: test-failure-server-side-route-resolution-${{ matrix.mode }}-${{ github.run_id }} | ||
| path: test-results-server-side-route-resolution-${{ matrix.mode }}.tar.gz | ||
| test-kit-svelte-async: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - mode: 'dev' | ||
| - mode: 'build' | ||
| steps: | ||
| - run: git config --global core.autocrlf false | ||
| - uses: actions/checkout@v5 | ||
| - uses: pnpm/[email protected] | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 24 | ||
| cache: pnpm | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm playwright install chromium | ||
| - run: pnpm run sync-all | ||
| - run: pnpm test:svelte-async:${{ matrix.mode }} | ||
| - name: Print flaky test report | ||
| run: node scripts/print-flaky-test-report.js | ||
| - name: Archive test results | ||
| if: failure() | ||
| shell: bash | ||
| run: find packages -type d -name test-results -not -empty | tar -czf test-results-svelte-async-${{ matrix.mode }}.tar.gz --files-from=- | ||
| - name: Upload test results | ||
| if: failure() | ||
| uses: actions/upload-artifact@v5 | ||
| with: | ||
| retention-days: 3 | ||
| name: test-failure-svelte-async-${{ matrix.mode }}-${{ github.run_id }} | ||
| path: test-results-svelte-async-${{ matrix.mode }}.tar.gz | ||
| test-others: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.