Skip to content

Conversation

@colinaaa
Copy link
Contributor

Description:

Automatically prevent the creation of miette::GraphicalReportHandler when no diagnostics are present.

BREAKING CHANGE: No

Related issue (if exists):

See performance regression in web-infra-dev/rspack#11006

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2025

⚠️ No Changeset found

Latest commit: be46f91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 14, 2025

CodSpeed Performance Report

Merging #10852 will not alter performance

Comparing colinaaa:colin/0714/to_pretty_string (be46f91) with main (7c57fbb)

Summary

✅ 140 untouched benchmarks

@colinaaa colinaaa marked this pull request as ready for review July 14, 2025 12:45
@colinaaa colinaaa requested a review from a team as a code owner July 14, 2025 12:45
@kdy1 kdy1 merged commit 93b318f into swc-project:main Jul 14, 2025
170 of 171 checks passed
@kdy1 kdy1 added this to the Planned milestone Jul 14, 2025
@kdy1
Copy link
Member

kdy1 commented Jul 14, 2025

Published with fd8b799

@kdy1 kdy1 modified the milestones: Planned, v1.13.0 Jul 17, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants