Skip to content

perf(swc_error_reporters): avoid creating miette handler when no diagnostics #10852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

perf(swc_error_reporters): avoid creating miette handler when no diagnostics #10852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions crates/swc_error_reporters/src/handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,18 @@ impl ThreadSafetyDiagnostics {
skip_filename: bool,
color: ColorConfig,
) -> Vec<String> {
let handler = to_pretty_handler(color);
self.0
let diagnostics = self
.0
.lock()
.expect("Failed to access the diagnostics lock")
.expect("Failed to access the diagnostics lock");

// If there are no diagnostics, return empty vector without initializing handler
if diagnostics.is_empty() {
return Vec::new();
}

let handler = to_pretty_handler(color);
diagnostics
.iter()
.map(|d| d.to_pretty_string(cm, skip_filename, &handler))
.collect::<Vec<String>>()
Expand Down
Loading