-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[ST-0017] Consolidate Swift Testing's image attachments API across platforms #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Oct 7, 2025
This PR applies the changes from [ST-NNNN](swiftlang/swift-evolution#2985). It merges `AttachableAsCGImage` and `AttachableAsIWICBitmapSource` into a single `AttachableAsImage` protocol and it adjusts the interfaces of `AttachableImageFormat` and `Attachment where AttachableValue: AttachableAsImage`.
2 tasks
0cacc5d to
0c1383b
Compare
0c1383b to
384df6d
Compare
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Oct 9, 2025
This PR applies the changes from [ST-NNNN](swiftlang/swift-evolution#2985). It merges `AttachableAsCGImage` and `AttachableAsIWICBitmapSource` into a single `AttachableAsImage` protocol and it adjusts the interfaces of `AttachableImageFormat` and `Attachment where AttachableValue: AttachableAsImage`.
384df6d to
bc2130d
Compare
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Oct 16, 2025
This PR applies the changes from [ST-NNNN](swiftlang/swift-evolution#2985). It merges `AttachableAsCGImage` and `AttachableAsIWICBitmapSource` into a single `AttachableAsImage` protocol and it adjusts the interfaces of `AttachableImageFormat` and `Attachment where AttachableValue: AttachableAsImage`.
…s' into jgrynspan/image-attachment-tweaks
- Assign the proposal ST-0017 - Rename the proposal document as appropriate - Update the relevant metadata about the current state of the proposal document
ffd097b to
623c223
Compare
younata
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links look good, metadata format matches. I'm going to merge this and then open the review thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here