Allow ToolsVersionParser to throw missing version tools error #8922
+50
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like we were catching this error and automatically adding the UnsupportedToolsVersion error with v3. Will investigate if this breaks any tests, but we probably want to persist the actual error
bkhouri
reviewed
Jul 11, 2025
| @@ -369,6 +369,31 @@ final class ToolsVersionParserTests: XCTestCase { | |||
| } | |||
| } | |||
|
|
|||
| /// Verifies that the correct error is thrown for each Swift tools version specification missing entirely.. | |||
There was a problem hiding this comment.
suggestion: Since we are modifying file, can we convert the suite to Swift Testing? maybe in a separate PR/commit?
There was a problem hiding this comment.
Sure! I'll make a separate issue for this.
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we were catching this error and automatically adding the UnsupportedToolsVersion error with v3.
Will investigate if this breaks any tests, but we probably want to persist the actual error here.