-
Notifications
You must be signed in to change notification settings - Fork 19
chore(z-index): add Z-Index utility #5741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
๐ฆ Changeset detectedLatest commit: b644760 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anything on my review isn't clear or you need help with anything, feel free to contact me and we can have a look together!
packages/documentation/src/stories/utilities/z-index/z-index.docs.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/z-index/z-index.docs.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/z-index/z-index.snapshot.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/z-index/z-index.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/z-index/z-index.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/z-index/z-index.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/z-index/z-index.styles.scss
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/z-index/z-index.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/z-index/z-index.styles.scss
Outdated
Show resolved
Hide resolved
Add snapshots for z-index Add visual regression tests for z-index Fix PR comments
โฆ/github.com/swisspost/design-system into 5631-create-z-index-utility-and-document-it
|
packages/documentation/src/stories/utilities/z-index/z-index.snapshot.stories.ts
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/z-index/z-index.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/utilities/z-index/z-index.styles.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is approved, but if you could quickly change in packages/documentation/src/stories/utilities/z-index/z-index.styles.scss
the formatting as there are some spaces missing. The best thing would be to have prettier "Autoformat on save" set up on your vscode, that way it does it automatically!
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.โ ๏ธ โ ๏ธ โ ๏ธ โ ๏ธ โ ๏ธ โ ๏ธ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.โ ๏ธ โ ๏ธ โ ๏ธ โ ๏ธ โ ๏ธ โ ๏ธ # Releases ## @swisspost/[email protected] ### Major Changes - Renamed the following CSS custom properties: - `--post-global-header-height` โ `--post-global-header-expanded-height` - `--post-local-header-height` โ `--post-local-header-expanded-height` - `--post-local-header-min-height` โ `--post-local-header-expanded-min-height` (by [@alizedebray](https://github.com/alizedebray) with [#5933](#5933)) ### Minor Changes - Internalized bootstrap z-index utilities. (by [@hugomslv](https://github.com/hugomslv) with [#5741](#5741)) ## @swisspost/[email protected] ### Minor Changes - Enabled use of the `post-header` component without requiring a `post-mainnavigation`. (by [@alizedebray](https://github.com/alizedebray) with [#5933](#5933)) ### Patch Changes - Updated `<post-tooltip>` by moving the `role` attribute from the `<post-tooltip>` to the nested `<post-popovercontainer>` component to improve accessibility. (by [@myrta2302](https://github.com/myrta2302) with [#5551](#5551)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added icons: `2696` and `2697` (by [@swisspost-bot](https://github.com/swisspost-bot) with [#5993](#5993)) ### Patch Changes - Updated icons: - `help` (line & solid): 16, 24, 32, 40, 48 and 64px - `info` (line & solid): 16, 24, 32, 40, 48 and 64px - `success` (line & solid): 16, 24, 32, 40, 48 and 64px - `warning` (line & solid): 16, 24, 32, 40, 48 and 64px (by [@swisspost-bot](https://github.com/swisspost-bot) with [#6005](#6005)) ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Internalized bootstrap z-index utilities. (by [@hugomslv](https://github.com/hugomslv) with [#5741](#5741)) ### Patch Changes - Enabled use of the `post-header` component without requiring a `post-mainnavigation`. (by [@alizedebray](https://github.com/alizedebray) with [#5933](#5933)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
๐ Description
add Z-index utility
๐ Demo
If applicable, please add a screenshot or video to illustrate the changes.
๐ Checklist