Skip to content

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Aug 3, 2025

Whew working on #379 I found that normalization was incorrectly handle multi-byte characters, for example, Euro character €. It is encoded in UTF-8 as e2 82 ac and previously would be replaced by \n

…aracters that should be normalized

For example, the Euro sign encoded as [e2 82 ac] previously would be replaced by \n
@Mingun Mingun added the bug label Aug 3, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.78%. Comparing base (38b44d4) to head (b26e2f4).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
+ Coverage   55.52%   55.78%   +0.25%     
==========================================
  Files          42       42              
  Lines       15511    15602      +91     
==========================================
+ Hits         8613     8704      +91     
  Misses       6898     6898              
Flag Coverage Δ
unittests 55.78% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mingun Mingun merged commit 6a6d23c into tafia:master Aug 3, 2025
7 checks passed
@Mingun Mingun deleted the fix-eol-normalziation branch August 3, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants