Skip to content

Conversation

@davide-zanon
Copy link
Contributor

@davide-zanon davide-zanon commented Oct 28, 2025

Description

This pull request creates a method to enable users to use the alpha API for Compute Engine.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@davide-zanon davide-zanon requested review from a team as code owners October 28, 2025 08:37
@snippet-bot
Copy link

snippet-bot bot commented Oct 28, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@hp1100
Copy link

hp1100 commented Oct 28, 2025

LGTM. nit: maybe add https://cloud.google.com/compute/docs/reference/rest/alpha#allow-policy in comments to remind customer to allow enable preview feature

@davide-zanon
Copy link
Contributor Author

LGTM. nit: maybe add https://cloud.google.com/compute/docs/reference/rest/alpha#allow-policy in comments to remind customer to allow enable preview feature

Thanks, Huici! This change is to display the Terraform code samples only. Any other text that we add before or after the code sample is handled within the documentation. See an example: https://cloud.google.com/compute/docs/instances/reservations-single-project#specify-vm-properties

@glasnt
Copy link
Contributor

glasnt commented Oct 28, 2025

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Oct 29, 2025

There is an organisation policy preventing the CI project from enabling preview features. Does this code work in a project without this restriction?

We can accept this code by disabling tests, if required.

@davide-zanon
Copy link
Contributor Author

There is an organisation policy preventing the CI project from enabling preview features. Does this code work in a project without this restriction?

We can accept this code by disabling tests, if required.

That's required by the feature. See https://cloud.google.com/compute/docs/reference/rest/alpha#allow-policy.

And, yes, if we could disable tests, that would be great. Many thanks!

@glasnt
Copy link
Contributor

glasnt commented Oct 29, 2025

/gcbrun go brr

@glasnt glasnt merged commit b897891 into terraform-google-modules:main Oct 29, 2025
4 checks passed
@davide-zanon davide-zanon deleted the patch-7 branch November 4, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants