-
Notifications
You must be signed in to change notification settings - Fork 286
Created Terraform sample to enable Private Preview features #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
LGTM. nit: maybe add https://cloud.google.com/compute/docs/reference/rest/alpha#allow-policy in comments to remind customer to allow enable preview feature |
Thanks, Huici! This change is to display the Terraform code samples only. Any other text that we add before or after the code sample is handled within the documentation. See an example: https://cloud.google.com/compute/docs/instances/reservations-single-project#specify-vm-properties |
|
/gcbrun |
|
There is an organisation policy preventing the CI project from enabling preview features. Does this code work in a project without this restriction? We can accept this code by disabling tests, if required. |
That's required by the feature. See https://cloud.google.com/compute/docs/reference/rest/alpha#allow-policy. And, yes, if we could disable tests, that would be great. Many thanks! |
|
/gcbrun go brr |
Description
This pull request creates a method to enable users to use the alpha API for Compute Engine.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/compute/docs/reference/rest/alpha
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review