Skip to content

[WIP] Add scripts for sparse elf generation #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions sparsity-testing-scripts/create_mem_bin.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this script since this was just for testing

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# create_mem_bin.py
import struct

def create_mem_bin(filename, total_size=0x10000000, pattern=0xDEADBEEF):
with open(filename, 'wb') as f:
# Write first 16 bytes (4 repetitions of 0xDEADBEEF)
for _ in range(4):
f.write(struct.pack('<I', pattern)) # Little endian
# Write the remaining bytes as zeros
remaining = total_size - 16
chunk_size = 4096 # Write in chunks to handle large sizes
zero_chunk = b'\x00' * chunk_size
while remaining > 0:
write_size = min(chunk_size, remaining)
f.write(zero_chunk[:write_size])
remaining -= write_size

if __name__ == '__main__':
create_mem_bin('mem.bin')
218 changes: 218 additions & 0 deletions sparsity-testing-scripts/create_mem_regions.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script creates the .o files needed for the linker script that's generated... why is this a separate script. I would try to combine the two files together s.t. you do:

  1. Scan the memory regions to create the metadata file (C++ executable)
  2. Given the metadata and elf, create all the .o's/etc + linker script
  3. Pass that output to a automated way to generate the final elf file.

Original file line number Diff line number Diff line change
@@ -0,0 +1,218 @@
#!/usr/bin/env python3

import sys
import struct
import os

def parse_regions(regions_file):
"""
Parses the regions.txt file and returns a list of tuples containing start addresses and sizes.
"""
regions = []
with open(regions_file, 'r') as f:
for line in f:
# Skip empty lines and comments
if not line.strip() or line.startswith('#'):
continue
parts = line.strip().split()
if len(parts) != 2:
print(f"Warning: Invalid line format: {line.strip()}")
continue
start_str, size_str = parts
try:
start = int(start_str, 16)
size = int(size_str, 10)
regions.append( (start, size) )
except ValueError:
print(f"Warning: Invalid hexadecimal number in line: {line.strip()}")
continue
return regions

def read_elf_header(f):
"""
Reads the ELF header from the file and returns a dictionary with relevant fields.
"""
f.seek(0)
# ELF header for 64-bit little endian
elf_header_struct = struct.Struct('<16sHHIQQQIHHHHHH')
elf_header_data = f.read(elf_header_struct.size)
unpacked = elf_header_struct.unpack(elf_header_data)

elf_header = {
'e_ident': unpacked[0],
'e_type': unpacked[1],
'e_machine': unpacked[2],
'e_version': unpacked[3],
'e_entry': unpacked[4],
'e_phoff': unpacked[5],
'e_shoff': unpacked[6],
'e_flags': unpacked[7],
'e_ehsize': unpacked[8],
'e_phentsize': unpacked[9],
'e_phnum': unpacked[10],
'e_shentsize': unpacked[11],
'e_shnum': unpacked[12],
'e_shstrndx': unpacked[13],
}
return elf_header

def read_program_headers(f, elf_header):
"""
Reads all program headers and returns a list of dictionaries.
"""
program_headers = []
f.seek(elf_header['e_phoff'])
ph_struct = struct.Struct('<IIQQQQQQ') # For 64-bit ELF
for _ in range(elf_header['e_phnum']):
ph_data = f.read(elf_header['e_phentsize'])
if len(ph_data) < ph_struct.size:
print("Error: Incomplete program header.")
sys.exit(1)
unpacked = ph_struct.unpack(ph_data[:ph_struct.size])
ph = {
'p_type': unpacked[0],
'p_flags': unpacked[1],
'p_offset': unpacked[2],
'p_vaddr': unpacked[3],
'p_paddr': unpacked[4],
'p_filesz': unpacked[5],
'p_memsz': unpacked[6],
'p_align': unpacked[7],
}
program_headers.append(ph)
return program_headers

def extract_data(f, program_headers, start_va, size):
"""
Extracts 'size' bytes of data from 'f' starting at virtual address 'start_va'.
"""
data = bytearray()
end_va = start_va + size
for ph in program_headers:
if ph['p_type'] != 1: # PT_LOAD
continue
seg_start = ph['p_vaddr']
seg_end = seg_start + ph['p_memsz']
# Check if segment overlaps with the region
if seg_end <= start_va or seg_start >= end_va:
continue
# Calculate overlap
overlap_start = max(start_va, seg_start)
overlap_end = min(end_va, seg_end)
overlap_size = overlap_end - overlap_start
# Calculate file offset
offset = ph['p_offset'] + (overlap_start - ph['p_vaddr'])
# Read the data
f.seek(offset)
chunk = f.read(overlap_size)
if len(chunk) < overlap_size:
print(f"Warning: Could not read enough data for VA 0x{overlap_start:X}")
chunk += b'\x00' * (overlap_size - len(chunk))
# Calculate where to place the data in the region
region_offset = overlap_start - start_va
# Ensure data array is big enough
while len(data) < region_offset:
data += b'\x00'
# Insert data_chunk at the correct offset
if len(data) < region_offset + overlap_size:
data += b'\x00' * (region_offset + overlap_size - len(data))
data[region_offset:region_offset + overlap_size] = chunk
# After processing all segments, ensure data is exactly 'size' bytes
if len(data) < size:
data += b'\x00' * (size - len(data))
elif len(data) > size:
data = data[:size]
return data

def create_binary_file(data, output_bin):
"""
Writes the binary data to 'output_bin'.
"""
with open(output_bin, 'wb') as f:
f.write(data)

def create_assembly_file(symbol_name, section_name, data_bin, output_asm):
"""
Creates an assembly file that defines a section containing the binary data.
"""
with open(output_asm, 'w') as f:
f.write(f"/* {output_asm} - Auto-generated Assembly File */\n\n")
f.write(f" .section {section_name}, \"aw\", @progbits\n")
f.write(f" .global {symbol_name}\n")
f.write(f"{symbol_name}:\n")
f.write(f" .incbin \"{data_bin}\"\n\n")

def assemble_section(asm_file, obj_file):
"""
Assembles the assembly file into an object file using the RISC-V assembler.
"""
import subprocess
cmd = ['riscv64-unknown-elf-as', '-o', obj_file, asm_file]
try:
subprocess.check_call(cmd)
except subprocess.CalledProcessError as e:
print(f"Error: Assembly failed for {asm_file}: {e}")
sys.exit(1)

def main():
if len(sys.argv) != 3:
print("Usage: python3 extract_regions.py <mem.elf> <regions.txt>")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, all scripts should use a shebang. See

#!/usr/bin/env bash
#!/usr/bin/env python
for examples.

sys.exit(1)

mem_elf = sys.argv[1]
regions_file = sys.argv[2]

# Check if mem.elf exists
if not os.path.isfile(mem_elf):
print(f"Error: File '{mem_elf}' does not exist.")
sys.exit(1)

# Check if regions.txt exists
if not os.path.isfile(regions_file):
print(f"Error: File '{regions_file}' does not exist.")
sys.exit(1)

regions = parse_regions(regions_file)
if not regions:
print("Error: No valid regions found in regions.txt.")
sys.exit(1)

# Open mem.elf
with open(mem_elf, 'rb') as f:
elf_header = read_elf_header(f)
# Verify ELF Magic Number
if elf_header['e_ident'][:4] != b'\x7fELF':
print("Error: Not a valid ELF file.")
sys.exit(1)
# Verify 64-bit ELF
if elf_header['e_ident'][4] != 2:
print("Error: Only 64-bit ELF files are supported.")
sys.exit(1)
# Parse program headers
program_headers = read_program_headers(f, elf_header)

for idx, (start, size) in enumerate(regions):
print(f"Processing region {idx}: Start=0x{start:X}, Size=0x{size:X}")
data = extract_data(f, program_headers, start, size)

# Create binary file
data_bin = f"data_mem{idx}.bin"
create_binary_file(data, data_bin)
print(f" Created binary file: {data_bin}")

# Create assembly file
section_name = f".data_mem{idx}"
symbol_name = f"data_mem{idx}" # Changed symbol name to avoid leading '.'
asm_file = f"data_mem{idx}.S"
create_assembly_file(symbol_name, section_name, data_bin, asm_file)
print(f" Created assembly file: {asm_file}")

# Assemble into .o file
obj_file = f"data_mem{idx}.o"
assemble_section(asm_file, obj_file)
print(f" Assembled object file: {obj_file}")

print("All memory regions processed successfully.")

if __name__ == "__main__":
main()
83 changes: 83 additions & 0 deletions sparsity-testing-scripts/linker_script_gen.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
#!/usr/bin/env python3

# generate_linker_script.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Cleanup all non-relevant comments. In this case, this comment says nothing.


import sys

def generate_linker_script(regions, output_filename):
with open(output_filename, 'w') as f:
f.write("/* sparse_mem.ld - Auto-generated Linker Script */\n\n")

# Define a single MEMORY region
f.write("MEMORY\n")
f.write("{\n")
f.write(" MEM (rwx) : ORIGIN = 0x80000000, LENGTH = 0x80000000\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This length should be auto-generated based on the regions. last_region_addr + chunk - origin_addr.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The start can also be autogenerated based on the 1st region addr.

f.write("}\n\n")

# Define SECTIONS with specified origin addresses
f.write("SECTIONS\n")
f.write("{\n")
for idx, (start, size, mem_region) in enumerate(regions):
section_name = f".data_mem{idx}"
f.write(f" {section_name} 0x{start:X} :\n")
f.write(" {\n")
f.write(f" KEEP(*({section_name}))\n")
f.write(" } > ")
f.write(f"{mem_region}\n\n")

# Standard sections
f.write(" .text :\n")
f.write(" {\n")
f.write(" *(.text)\n")
f.write(" } > MEM\n\n")

f.write(" .bss :\n")
f.write(" {\n")
f.write(" *(.bss)\n")
f.write(" *(COMMON)\n")
f.write(" } > MEM\n\n")

f.write(" /* Additional sections can be defined here */\n")
f.write("}\n")

def parse_regions_with_memory(regions_file):
"""
Parses regions.txt and assigns each region to the single MEMORY region MEM.
Assumes regions.txt has lines with: start_address size
Comment on lines +45 to +46
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*.txt?

Sizes are specified in decimal.
"""
regions = []
with open(regions_file, 'r') as rf:
for line in rf:
parts = line.strip().split()
if len(parts) != 2:
continue
start_str, size_str = parts
try:
start = int(start_str, 16) # Start address in hexadecimal
size = int(size_str, 10) # Size in decimal
mem_region = "MEM" # Single memory region
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might confuse others why there is only a single memory region, also if this is the case (only 1 memory region) no need to have code to assign this to each region, just assume this in the upper function.

regions.append( (start, size, mem_region) )
except ValueError:
print(f"Warning: Invalid number format in line: {line.strip()}")
continue
return regions

def main():
if len(sys.argv) != 3:
print("Usage: python3 generate_linker_script.py <regions_file> <output_ld_file>")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Consistent naming between the different files ("regions_file" vs "metadata_file"). "regions_file" I think is better.

sys.exit(1)

regions_file = sys.argv[1]
output_ld_file = sys.argv[2]

regions = parse_regions_with_memory(regions_file)
if not regions:
print("Error: No valid regions found in regions.txt.")
sys.exit(1)

generate_linker_script(regions, output_ld_file)
print(f"Linker script '{output_ld_file}' generated successfully.")

if __name__ == "__main__":
main()
Loading
Loading