refactor: increase min-height for grid cells in base styles #10315
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
vursen
force-pushed
the
increase-min-height-for-grid-rows
branch
2 times, most recently
from
ec62dfb to
05c15b8
Compare
vursen
force-pushed
the
increase-min-height-for-grid-rows
branch
from
05c15b8 to
b28509e
Compare
|
vursen
commented
Oct 27, 2025
| fixtureSync(` | ||
| <style> | ||
| :root { | ||
| --vaadin-grid-row-border-width: 0px; |
There was a problem hiding this comment.
There is an issue in the base styles caused by how borders are currently implemented, which causes Grid to incorrectly treat items under the header as visible. This should be addressed separately by refactoring the border implementation: #10331
tomivirkki
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
min-height: 1lhto[part~='cell'] ::slotted(vaadin-grid-cell-content)which increases the cell's default minimum height from12pxto32px. This in turn prevents the virtualizer from creating excess buffer rows and, as a result, noticeably improves page rendering time in Aura:(measured with 4x CPU throttle on
/dev/playground/grid.html)