Skip to content

refactor: increase min-height for grid cells in base styles #10315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 27, 2025
+11 −0
Merged

refactor: increase min-height for grid cells in base styles #10315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5bd2ff7
refactor: increase min-height for grid rows in base styles
vursen Oct 13, 2025
27d0e17
Update packages/grid/src/styles/vaadin-grid-base-styles.js
vursen Oct 13, 2025
ab6a7b4
disable negative margins to avoid rows under header being considered …
vursen Oct 14, 2025
9b32469
wip
vursen Oct 15, 2025
de73180
wip
vursen Oct 16, 2025
b28509e
disable grid borders in crud test
vursen Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/crud/test/a11y.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ describe('a11y', () => {
await setViewport({ width: 1024, height: 768 });
});

beforeEach(() => {
fixtureSync(`
<style>
:root {
--vaadin-grid-row-border-width: 0px;
Copy link
Contributor Author

@vursen vursen Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue in the base styles caused by how borders are currently implemented, which causes Grid to incorrectly treat items under the header as visible. This should be addressed separately by refactoring the border implementation: #10331

}
</style>
`);
});

function focusRestorationTests(testId, createFixture) {
describe(`focus restoration - ${testId}`, () => {
let grid, form, dialog, newButton, saveButton, cancelButton, editButtons;
Expand Down
1 change: 1 addition & 0 deletions packages/grid/src/styles/vaadin-grid-base-styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,7 @@ export const gridStyles = css`
text-overflow: ellipsis;
padding: var(--vaadin-grid-cell-padding, var(--vaadin-padding-container));
flex: 1;
min-height: 1lh;
min-width: 0;
}

Expand Down