Skip to content

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Aug 28, 2025

Copy link

netlify bot commented Aug 28, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit b7d6b8b
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/68b19ec682edd200083d2ba3
😎 Deploy Preview https://deploy-preview-4590--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Apply proposed styles from #1130 (comment)

Closes #1130
@patrickhlauke patrickhlauke force-pushed the patrickhlauke-spec-sc-box-restyle branch from 44f4fdc to 2baec87 Compare August 28, 2025 22:49
@patrickhlauke
Copy link
Member Author

patrickhlauke commented Aug 28, 2025

had to reduce the negative top margin to just -0.5em, as my original -3em was causing a clash with long SC names, and I was not in the mood (yet) to rework the whole layout/structure of the entire thing to avoid it

screenshot showing 'Success Criterion 1.2.3 Audio Description or Media Alternative (Prerecorded)' overlapping the top of the styled doclinks box

I also wasn't able to find where the <br> is injected, so i display:none'd it

@patrickhlauke patrickhlauke self-assigned this Aug 28, 2025
@iadawn
Copy link
Contributor

iadawn commented Aug 29, 2025

@kfranqueiro Could you see if you could find the errant <br>? Once done I am happy for this to merge and we can work with webmaster to get it published.

@kfranqueiro
Copy link
Contributor

@kfranqueiro Could you see if you could find the errant <br>? Once done I am happy for this to merge and we can work with webmaster to get it published.

Done

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Aug 29, 2025

Looks like this has spotted a bug in my TR-vs.-informative check. That failure should be ignored, because this PR only touches TR space.

(Update: will be fixed by #4593)

@patrickhlauke
Copy link
Member Author

ah, magic, thanks @kfranqueiro (now realise why I didn't spot it...had my site-wide search in VS code filtered to just look at .html and .css files, oops)

@bruce-usab bruce-usab self-requested a review August 29, 2025 14:33
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

For reviewers, here‘s the link to same bookmark as as in OP.

(Also, I attempted a diff version but it is not of utility as the boxes for Understanding and How To are not visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font size used in Understanding/How to Meet links is 7.5pt
5 participants