Skip to content

Conversation

kfranqueiro
Copy link
Contributor

This fixes a bug in the "isolation of changes to TR space or informative docs" check, which only considered guidelines to be TR space, disregarding scripts where wcag.js is stored.

Testing with the branch for #4590...

Old commands:

$ git diff main --numstat | grep -c '\sguidelines'
1
$ git diff main --numstat | grep -vc '\sguidelines'
1

New commands:

$ git diff main --numstat | egrep -c '\sguidelines/|\sscript/'
2
$ git diff main --numstat | egrep -vc '\sguidelines/|\sscript/'
0

(The check fails when the number is nonzero on both sides.)

@kfranqueiro kfranqueiro requested a review from iadawn August 29, 2025 12:08
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 50104f8
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/68b1984ab0773c0008585402
😎 Deploy Preview https://deploy-preview-4593--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kfranqueiro kfranqueiro merged commit 0f22a30 into main Aug 29, 2025
6 checks passed
@kfranqueiro kfranqueiro deleted the kgf-fix-tr-check branch August 29, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants