Skip to content

Conversation

@stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Dec 2, 2025

Summary

We don't need to specifiler toml files in npm scripts for taplo

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 2, 2025 08:26
@netlify
Copy link

netlify bot commented Dec 2, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit aae32ed
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/692ea2a56924070008be61d3

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 2, 2025
Copilot finished reviewing on behalf of stormslowly December 2, 2025 08:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the taplo format configuration to properly include all TOML files in the repository, particularly xtask/Cargo.toml which was previously excluded. The fix simplifies the format commands to rely on the .taplo.toml configuration file rather than passing explicit file patterns as command-line arguments.

Key changes:

  • Updated .taplo.toml glob pattern from xtask/*/*.toml to xtask/**/*.toml to include TOML files at all depth levels
  • Simplified package.json taplo scripts to remove redundant file path arguments
  • Applied taplo formatting to previously unformatted TOML files (alphabetical sorting and alignment)

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.taplo.toml Fixed glob pattern to correctly match xtask/Cargo.toml using ** instead of *
package.json Simplified taplo format commands to rely on .taplo.toml configuration
xtask/Cargo.toml Applied taplo formatting: alphabetically sorted and aligned dependencies
crates/rspack_tracing_perfetto/Cargo.toml Moved allocative dependency to alphabetically correct position
crates/rspack_plugin_real_content_hash/Cargo.toml Alphabetically sorted lint configuration keys
crates/rspack_plugin_mf/Cargo.toml Alphabetically sorted lint configuration keys
crates/rspack_plugin_html/Cargo.toml Alphabetically sorted lint configuration keys
crates/rspack_loader_swc/Cargo.toml Alphabetically sorted lint configuration keys
crates/rspack_collections/Cargo.toml Moved allocative to correct position, sorted lint keys, removed trailing line
crates/rspack_cacheable/Cargo.toml Alphabetically sorted lint configuration keys

Note: The PR title contains a typo ("foramt" should be "format"), which should be corrected.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 822.6 KB - -
📄 JavaScript 822.6 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.3 KB - -
📄 JavaScript 984.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

📦 Binary Size-limit

Comparing aae32ed to chore(workflow): run diff CI on push events (#12346) by yifancong

🙈 Size remains the same at 47.70MB

@stormslowly stormslowly changed the title chore: fix taplo foramt script chore: fix taplo format script Dec 2, 2025
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenjiahan chenjiahan enabled auto-merge (squash) December 2, 2025 08:39
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 2, 2025

CodSpeed Performance Report

Merging #12349 will not alter performance

Comparing chore/fix_toml_format (aae32ed) with main (8bcf8af)

Summary

✅ 17 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants