-
-
Notifications
You must be signed in to change notification settings - Fork 738
chore: fix taplo format script #12349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the taplo format configuration to properly include all TOML files in the repository, particularly xtask/Cargo.toml which was previously excluded. The fix simplifies the format commands to rely on the .taplo.toml configuration file rather than passing explicit file patterns as command-line arguments.
Key changes:
- Updated
.taplo.tomlglob pattern fromxtask/*/*.tomltoxtask/**/*.tomlto include TOML files at all depth levels - Simplified
package.jsontaplo scripts to remove redundant file path arguments - Applied taplo formatting to previously unformatted TOML files (alphabetical sorting and alignment)
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.taplo.toml |
Fixed glob pattern to correctly match xtask/Cargo.toml using ** instead of * |
package.json |
Simplified taplo format commands to rely on .taplo.toml configuration |
xtask/Cargo.toml |
Applied taplo formatting: alphabetically sorted and aligned dependencies |
crates/rspack_tracing_perfetto/Cargo.toml |
Moved allocative dependency to alphabetically correct position |
crates/rspack_plugin_real_content_hash/Cargo.toml |
Alphabetically sorted lint configuration keys |
crates/rspack_plugin_mf/Cargo.toml |
Alphabetically sorted lint configuration keys |
crates/rspack_plugin_html/Cargo.toml |
Alphabetically sorted lint configuration keys |
crates/rspack_loader_swc/Cargo.toml |
Alphabetically sorted lint configuration keys |
crates/rspack_collections/Cargo.toml |
Moved allocative to correct position, sorted lint keys, removed trailing line |
crates/rspack_cacheable/Cargo.toml |
Alphabetically sorted lint configuration keys |
Note: The PR title contains a typo ("foramt" should be "format"), which should be corrected.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Rsdoctor Bundle Diff AnalysisFound 5 project(s) in monorepo. 📁 react-10kPath:
📁 react-1kPath:
📁 react-5kPath:
📁 romePath:
📁 ui-componentsPath:
Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🙈 Size remains the same at 47.70MB |
chenjiahan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CodSpeed Performance ReportMerging #12349 will not alter performanceComparing Summary
|
Summary
We don't need to specifiler toml files in npm scripts for taplo
Related links
Checklist