-
Couldn't load subscription status.
- Fork 216
Handling source id / refund id / intent ids metas in the order helper class #4693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mayisha <[email protected]>
Co-authored-by: Mayisha <[email protected]>
Co-authored-by: Mayisha <[email protected]>
Co-authored-by: Mayisha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes. Looks good overall. Requesting changes due to missing parameters in some of the update* functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Wesley
This looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Smoke tested on simple purchases, subscriptions and renewals.
Left a question above.
Base PR #4613
P2 peNR48-1Jc-p2
Changes proposed in this Pull Request:
As part of the Order Helper class project, I am including some additional meta keys to be handled by the new class and implementing the new methods across our codebase.
The metas handled here are:
_stripe_source_id,_stripe_refund_id,_stripe_intent_id, and_stripe_setup_intent.Testing instructions
Changelog entry
Changelog Entry Comment
Comment
Post merge