Skip to content

Conversation

@wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Sep 23, 2025

Base PR #4613
P2 peNR48-1Jc-p2

Changes proposed in this Pull Request:

As part of the Order Helper class project, I am including some additional meta keys to be handled by the new class and implementing the new methods across our codebase.

The metas handled here are: _stripe_source_id, _stripe_refund_id, _stripe_intent_id, and _stripe_setup_intent.

Testing instructions

  • Code review
  • Check if the tests are still passing
  • Perform some basic smoke testing to confirm no regression was introduced

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa changed the title Handling source id meta Handling source id meta in the order helper class Sep 23, 2025
@wjrosa wjrosa changed the title Handling source id meta in the order helper class Handling source id / refund id / intent ids metas in the order helper class Sep 23, 2025
@wjrosa wjrosa marked this pull request as ready for review September 23, 2025 16:10
@wjrosa wjrosa marked this pull request as draft September 24, 2025 12:33
@wjrosa wjrosa marked this pull request as ready for review September 26, 2025 18:30
@wjrosa wjrosa requested review from a team, annemirasol and malithsen and removed request for a team September 26, 2025 20:34
Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes. Looks good overall. Requesting changes due to missing parameters in some of the update* functions.

@wjrosa wjrosa requested a review from malithsen September 30, 2025 11:19
Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wesley

This looks good to me

Copy link

@annemirasol annemirasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Smoke tested on simple purchases, subscriptions and renewals.

Left a question above.

@wjrosa wjrosa merged commit 16200ab into develop Oct 1, 2025
41 of 42 checks passed
@wjrosa wjrosa deleted the dev/handling-source-id-meta branch October 1, 2025 16:44
@daledupreez daledupreez added this to the 10.0.0 milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants