Clean AppSwitch hash params on Pay for Order page (5031) #3562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other contexts, the Pay for Order page does not process the payment over AJAX, it uses a regular form submission.
When there is an error during payment processing on this page, there is no way to notify that to the frontend before or after the page is reloaded. Since the AppSwitch hash params are still present in the URL upon reload, the AppSwitch flow is triggered again, causing an infinite reload loop.
To fix this, this PR adds code to preemptively remove the hash params from the URL on the onApprove callback, before the payment is processed.