openssl: skip patch Configurations when version <= 1.1.0 (#8282)

[Cillo-x]

fix issue #8282

[gemini-code-assist]

Summary of Changes

Hello @Cillo-x, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a compatibility issue by conditionally applying a patch related to OpenSSL's Configurations directory. The change ensures that the _fix_overlong_make_recipe patch, which is designed for newer OpenSSL versions, is correctly skipped for older versions (1.1.0 and below) that lack the targeted directory. This prevents potential build failures or incorrect behavior when compiling OpenSSL with xmake.

Highlights

• OpenSSL Version Compatibility: Introduced a version check to ensure that a specific patch, _fix_overlong_make_recipe, is only applied to OpenSSL versions greater than 1.1.0.
• Patch Application Logic: The _fix_overlong_make_recipe patch is now skipped for OpenSSL versions 1.1.0 and older because these versions do not contain the Configurations directory that the patch targets.
• Issue Resolution: This change directly addresses and fixes issue openssl configure/patch.lua 有问题导致旧版本 [1.0.2-u] 无法开始编译 #8282, which likely stemmed from applying the patch to incompatible older OpenSSL versions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a version check to skip a patch for older OpenSSL versions that don't have the Configurations directory. The intention is correct, but the version comparison logic has a subtle bug. I've provided a comment with a suggested fix to ensure the patch is applied correctly for all relevant OpenSSL versions.

[gemini-code-assist]

The version check le("1.1.0") (less than or equal to) appears to be incorrect. The Configurations directory, which this patch targets, was introduced in OpenSSL 1.1.0. Therefore, the patch should be applied to version 1.1.0 and later. The current logic le would incorrectly skip the patch for version 1.1.0 itself.

The condition should check for versions less than 1.1.0. Using lt("1.1.0") would be correct.

This logic seems to be copied from other functions in this file (_remove_unused_pod_usage and _replace_NUL_with_null), so this correction should likely be applied there as well for consistency and correctness.

    if package:version():lt("1.1.0") then