Skip to content

Added method "fallbackExceptionMessage" to customize fallback exception message #20681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Added method "fallbackExceptionMessage" to customize fallback exception message #20681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion framework/base/ErrorHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ protected function handleFallbackExceptionMessage($exception, $previousException
}
$msg .= "\n\$_SERVER = " . VarDumper::export($_SERVER);
} else {
echo 'An internal server error occurred.';
echo $this->fallbackExceptionMessage($exception);
}
error_log($msg);
if (defined('HHVM_VERSION')) {
Expand All @@ -197,6 +197,11 @@ protected function handleFallbackExceptionMessage($exception, $previousException
exit(1);
}

protected function fallbackExceptionMessage($exception)
Copy link
Contributor

@mspirkov mspirkov Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a dock block missing here.
It's worth adding the @param annotation for $exception.

{
return 'An internal server error occurred.';
}

/**
* Handles HHVM execution errors such as warnings and notices.
*
Expand Down
Loading