Skip to content

msglist: Support viewing who reacted to a message #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/icons/ZulipIcons.ttf
Binary file not shown.
6 changes: 6 additions & 0 deletions assets/icons/see_who_reacted.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
31 changes: 31 additions & 0 deletions assets/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,37 @@
"@errorUnresolveTopicFailedTitle": {
"description": "Error title when marking a topic as unresolved failed."
},
"actionSheetOptionSeeWhoReacted": "See who reacted",
"@actionSheetOptionSeeWhoReacted": {
"description": "Label for the 'See who reacted' button in the message action sheet."
},
"seeWhoReactedSheetNoReactions": "This message has no reactions.",
"@seeWhoReactedSheetNoReactions": {
"description": "Explanation on the 'See who reacted' sheet when the message has no reactions (because they were removed after the sheet was opened)."
},
"seeWhoReactedSheetHeaderLabel": "Emoji reactions ({num})",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "total"?

Suggested change
"seeWhoReactedSheetHeaderLabel": "Emoji reactions ({num})",
"seeWhoReactedSheetHeaderLabel": "Emoji reactions ({num} total)",

Otherwise it kind of sounds like it's saying there are this many different reactions; at least I think that'd be my first guess as to the meaning.

"@seeWhoReactedSheetHeaderLabel": {
"description": "In the 'See who reacted' sheet, a label for the list of emoji reactions at the top, with the total number of reactions. (An accessibility label for assistive technology.)",
"placeholders": {
"num": {"type": "int", "example": "2"}
}
},
"seeWhoReactedSheetEmojiNameWithVoteCount": "{emojiName}: {num, plural, =1{1 vote} other{{num} votes}}",
"@seeWhoReactedSheetEmojiNameWithVoteCount": {
"description": "In the 'See who reacted' sheet, an emoji reaction's name and how many votes it has. (An accessibility label for assistive technology.)",
"placeholders": {
"emojiName": {"type": "String", "example": "working_on_it"},
"num": {"type": "int", "example": "2"}
}
},
"seeWhoReactedSheetUserListLabel": "Votes for {emojiName} ({num})",
"@seeWhoReactedSheetUserListLabel": {
"description": "In the 'See who reacted' sheet, a label for the list of users who chose an emoji reaction, with the emoji's name and how many votes it has. (An accessibility label for assistive technology.)",
"placeholders": {
"emojiName": {"type": "String", "example": "working_on_it"},
"num": {"type": "int", "example": "2"}
}
},
"actionSheetOptionCopyMessageText": "Copy message text",
"@actionSheetOptionCopyMessageText": {
"description": "Label for copy message text button on action sheet."
Expand Down
30 changes: 30 additions & 0 deletions lib/generated/l10n/zulip_localizations.dart
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,36 @@ abstract class ZulipLocalizations {
/// **'Failed to mark topic as unresolved'**
String get errorUnresolveTopicFailedTitle;

/// Label for the 'See who reacted' button in the message action sheet.
///
/// In en, this message translates to:
/// **'See who reacted'**
String get actionSheetOptionSeeWhoReacted;

/// Explanation on the 'See who reacted' sheet when the message has no reactions (because they were removed after the sheet was opened).
///
/// In en, this message translates to:
/// **'This message has no reactions.'**
String get seeWhoReactedSheetNoReactions;

/// In the 'See who reacted' sheet, a label for the list of emoji reactions at the top, with the total number of reactions. (An accessibility label for assistive technology.)
///
/// In en, this message translates to:
/// **'Emoji reactions ({num})'**
String seeWhoReactedSheetHeaderLabel(int num);

/// In the 'See who reacted' sheet, an emoji reaction's name and how many votes it has. (An accessibility label for assistive technology.)
///
/// In en, this message translates to:
/// **'{emojiName}: {num, plural, =1{1 vote} other{{num} votes}}'**
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num);

/// In the 'See who reacted' sheet, a label for the list of users who chose an emoji reaction, with the emoji's name and how many votes it has. (An accessibility label for assistive technology.)
///
/// In en, this message translates to:
/// **'Votes for {emojiName} ({num})'**
String seeWhoReactedSheetUserListLabel(String emojiName, int num);

/// Label for copy message text button on action sheet.
///
/// In en, this message translates to:
Expand Down
27 changes: 27 additions & 0 deletions lib/generated/l10n/zulip_localizations_ar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,33 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Failed to mark topic as unresolved';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Copy message text';

Expand Down
27 changes: 27 additions & 0 deletions lib/generated/l10n/zulip_localizations_de.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,33 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Thema konnte nicht als ungelöst markiert werden';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Nachrichtentext kopieren';

Expand Down
27 changes: 27 additions & 0 deletions lib/generated/l10n/zulip_localizations_en.dart
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,33 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Failed to mark topic as unresolved';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Copy message text';

Expand Down
27 changes: 27 additions & 0 deletions lib/generated/l10n/zulip_localizations_fr.dart
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,33 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Failed to mark topic as unresolved';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Copy message text';

Expand Down
27 changes: 27 additions & 0 deletions lib/generated/l10n/zulip_localizations_it.dart
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,33 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Impossibile contrassegnare l\'argomento come irrisolto';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Copia il testo del messaggio';

Expand Down
27 changes: 27 additions & 0 deletions lib/generated/l10n/zulip_localizations_ja.dart
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,33 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
@override
String get errorUnresolveTopicFailedTitle => 'トピックを未解決にできませんでした';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'メッセージ本文をコピー';

Expand Down
27 changes: 27 additions & 0 deletions lib/generated/l10n/zulip_localizations_nb.dart
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,33 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Failed to mark topic as unresolved';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Copy message text';

Expand Down
27 changes: 27 additions & 0 deletions lib/generated/l10n/zulip_localizations_pl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,33 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Nie udało się oznaczyć brak rozwiązania';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Skopiuj tekst wiadomości';

Expand Down
27 changes: 27 additions & 0 deletions lib/generated/l10n/zulip_localizations_ru.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,33 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
String get errorUnresolveTopicFailedTitle =>
'Не удалось отметить тему как нерешенную';

@override
String get actionSheetOptionSeeWhoReacted => 'See who reacted';

@override
String get seeWhoReactedSheetNoReactions => 'This message has no reactions.';

@override
String seeWhoReactedSheetHeaderLabel(int num) {
return 'Emoji reactions ($num)';
}

@override
String seeWhoReactedSheetEmojiNameWithVoteCount(String emojiName, int num) {
String _temp0 = intl.Intl.pluralLogic(
num,
locale: localeName,
other: '$num votes',
one: '1 vote',
);
return '$emojiName: $_temp0';
}

@override
String seeWhoReactedSheetUserListLabel(String emojiName, int num) {
return 'Votes for $emojiName ($num)';
}

@override
String get actionSheetOptionCopyMessageText => 'Скопировать текст сообщения';

Expand Down
Loading