-
Notifications
You must be signed in to change notification settings - Fork 61
Match Mode GUI Config [AARD-2026]
#1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think the button (and behavior) after going into that screen should be to save, rather than to start the match.
- I think that it makes more sense to have a toggle to enable the height limit and extension limit, rather than saying to put in the string "Infinity"
- I think having an edit button for an existing config (potentially instead of the delete button, and the delete button goes inside of the edit screen) would make sense
- If there's an easy way to do it, I think the checkmarks should be replaced with a play button to make it clearer what they do
Done
Done
I think this is out of the scope of this PR. Will make a separate Jira ticket for this
Done |
fission/src/ui/panels/configuring/CreateNewMatchModeConfigPanel.tsx
Outdated
Show resolved
Hide resolved
…l.tsx Co-authored-by: Zach Rutman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I do think that we should omit the id when downloading and uploading the JSON and have it generate one when uploading, since it doesn't really make much sense to keep and could potentially cause issues later (and just clutters the config file, if someone wanted to edit it manually). I can create a ticket for that since it's not within the scope of this PR.
Task
Match Mode GUI Config
AARD-2026
Symptom
Currently, if users want to customize the match length, penalties, etc., they have to make their own json file following proper syntax, which isn't exactly user friendly.
Solution
In the Match Mode Setup panel, a new option now exists to create a match mode config.


Pressing that opens up a new panel that guides the user to create their own config.
Pressing accept starts match mode with the new config, and also saves the config to local storage allowing it to be used again.
There is also a Download as json button at the bottom, that downloads the entire config as a json file, allowing it to be shared across multiple devices.
Verification
Before merging, ensure the following criteria are met: