Skip to content

Match Mode GUI Config [AARD-2026] #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from

Conversation

AlexD717
Copy link
Member

@AlexD717 AlexD717 commented Aug 11, 2025

Task

Match Mode GUI Config

AARD-2026

Symptom

Currently, if users want to customize the match length, penalties, etc., they have to make their own json file following proper syntax, which isn't exactly user friendly.

Solution

In the Match Mode Setup panel, a new option now exists to create a match mode config.
Screenshot 2025-08-11 101815
Pressing that opens up a new panel that guides the user to create their own config.
Screenshot 2025-08-11 101904
Pressing accept starts match mode with the new config, and also saves the config to local storage allowing it to be used again.
There is also a Download as json button at the bottom, that downloads the entire config as a json file, allowing it to be shared across multiple devices.

Verification

  • After creating a configuration and pressing accept, your defined values is applied to the match
  • Match mode config can be downloaded as a json, and then uploaded
  • Can't download an invalid json config
  • Can't enter letters into number only configs

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Aug 11, 2025
@AlexD717 AlexD717 added the ui/ux Relating to user interface, or in general, user experience label Aug 11, 2025
@AlexD717 AlexD717 marked this pull request as ready for review August 11, 2025 17:28
@AlexD717 AlexD717 requested review from a team as code owners August 11, 2025 17:28
Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think the button (and behavior) after going into that screen should be to save, rather than to start the match.
  2. I think that it makes more sense to have a toggle to enable the height limit and extension limit, rather than saying to put in the string "Infinity"
  3. I think having an edit button for an existing config (potentially instead of the delete button, and the delete button goes inside of the edit screen) would make sense
  4. If there's an easy way to do it, I think the checkmarks should be replaced with a play button to make it clearer what they do

@AlexD717
Copy link
Member Author

  1. I think the button (and behavior) after going into that screen should be to save, rather than to start the match.

Done

  1. I think that it makes more sense to have a toggle to enable the height limit and extension limit, rather than saying to put in the string "Infinity"

Done

  1. I think having an edit button for an existing config (potentially instead of the delete button, and the delete button goes inside of the edit screen) would make sense

I think this is out of the scope of this PR. Will make a separate Jira ticket for this

  1. If there's an easy way to do it, I think the checkmarks should be replaced with a play button to make it clearer what they do

Done

@AlexD717 AlexD717 requested a review from rutmanz August 12, 2025 18:03
@AlexD717 AlexD717 requested a review from rutmanz August 12, 2025 18:37
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I do think that we should omit the id when downloading and uploading the JSON and have it generate one when uploading, since it doesn't really make much sense to keep and could potentially cause issues later (and just clutters the config file, if someone wanted to edit it manually). I can create a ticket for that since it's not within the scope of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants