Add support for extra rustc environment variables #3510
+99
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for injecting environment variables into rustc invocations via build settings: - `//rust/settings:extra_rustc_env` for the target configuration - `//rust/settings:extra_exec_rustc_env` for the exec configuration These settings can be set from the command line with flags like: ``` --@rules_rust//rust/settings:extra_rustc_env=RUSTC_BOOTSTRAP=1 ``` This mirrors how extra rustc flags are handled and enables build-wide env-based feature control without editing individual rules. Useful for enabling unstable features across many crates, or toggling behavior in proc macros and build scripts.
nmattia
force-pushed
the
nm-extra-rustc-env
branch
from
a1ca705 to
87ec024
Compare
nmattia
added a commit
to dfinity/ic
that referenced
this pull request
Jul 18, 2025
This will allow us to keep up to date with new changes and to cherry-pick our patches more cleanly (bazelbuild/rules_rust#3434, bazelbuild/rules_rust#3510)
nmattia
added a commit
to dfinity/ic
that referenced
this pull request
Jul 18, 2025
this drops the nightly toolchain that was used in the fuzzers. Instead, `RUSTC_BOOTSTRAP=1` is set in the fuzzer targets, which has the same effect without requiring the download of a second toolchain. NOTE: This vendors the following upstream patch: bazelbuild/rules_rust#3510
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jul 21, 2025
This will allow us to keep up to date with new changes and to cherry-pick our patches more cleanly (bazelbuild/rules_rust#3434, bazelbuild/rules_rust#3510)
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jul 21, 2025
This will allow us to keep up to date with new changes and to cherry-pick our patches more cleanly (bazelbuild/rules_rust#3434, bazelbuild/rules_rust#3510)
nmattia
force-pushed
the
nm-extra-rustc-env
branch
from
179b2b4 to
356cea5
Compare
nmattia
added a commit
to dfinity/ic
that referenced
this pull request
Jul 21, 2025
this drops the nightly toolchain that was used in the fuzzers. Instead, `RUSTC_BOOTSTRAP=1` is set in the fuzzer targets, which has the same effect without requiring the download of a second toolchain. NOTE: This vendors the following upstream patch: bazelbuild/rules_rust#3510
nmattia
added a commit
to dfinity/ic
that referenced
this pull request
Jul 21, 2025
this drops the nightly toolchain that was used in the fuzzers. Instead, `RUSTC_BOOTSTRAP=1` is set in the fuzzer targets, which has the same effect without requiring the download of a second toolchain. NOTE: This vendors the following upstream patch: bazelbuild/rules_rust#3510
nmattia
added a commit
to dfinity/ic
that referenced
this pull request
Jul 21, 2025
this drops the nightly toolchain that was used in the fuzzers. Instead, `RUSTC_BOOTSTRAP=1` is set in the fuzzer targets, which has the same effect without requiring the download of a second toolchain. NOTE: This vendors the following upstream patch: bazelbuild/rules_rust#3510
nmattia
added a commit
to dfinity/ic
that referenced
this pull request
Jul 21, 2025
this drops the nightly toolchain that was used in the fuzzers. Instead, `RUSTC_BOOTSTRAP=1` is set in the fuzzer targets, which has the same effect without requiring the download of a second toolchain. NOTE: This vendors the following upstream patch: bazelbuild/rules_rust#3510
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Jul 21, 2025
this drops the nightly toolchain that was used in the fuzzers. Instead, `RUSTC_BOOTSTRAP=1` is set in the fuzzer targets, which has the same effect without requiring the download of a second toolchain. NOTE: This vendors the following upstream patch: bazelbuild/rules_rust#3510
Andrei1998
pushed a commit
to dfinity/ic
that referenced
this pull request
Jul 22, 2025
this drops the nightly toolchain that was used in the fuzzers. Instead, `RUSTC_BOOTSTRAP=1` is set in the fuzzer targets, which has the same effect without requiring the download of a second toolchain. NOTE: This vendors the following upstream patch: bazelbuild/rules_rust#3510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for injecting environment variables into rustc invocations via build settings:
//rust/settings:extra_rustc_envfor the target configuration//rust/settings:extra_exec_rustc_envfor the exec configurationThese settings can be set from the command line with flags like:
This mirrors how extra rustc flags are handled and enables build-wide env-based feature control without editing individual rules. Useful for enabling unstable features across many crates, or toggling behavior in proc macros and build scripts.