Skip to content

Fix volumetric fog render graph crash when bevy_post_process feature … #20931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix volumetric fog render graph crash when bevy_post_process feature … #20931

wants to merge 2 commits into from

Conversation

fairhill1
Copy link
Contributor

@fairhill1 fairhill1 commented Sep 8, 2025 •
edited
Loading

Fix volumetric fog render graph crash when bevy_post_process feature is disabled

adds conditional compilation so it only connects to bloom when the feature is enabled

tested compiling minimal exaple with PP off, no crash

Fixes #20923

@hukasu hukasu added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Sep 8, 2025
mockersf
mockersf requested changes Sep 8, 2025
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new bevy_post_process feature is never enabled and not exposed, which makes it impossible to enable from the bevy crate

@atlv24 atlv24 mentioned this pull request Sep 9, 2025
Merged
@github-project-automation github-project-automation bot moved this to Done in Rendering Sep 9, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 9, 2025
@atlv24
Add StartMainPassPostProcessing node for ordering (#20939)
369a760 
# Objective

- Fixes #20923
- Supersedes #20931

## Solution

- Add a StartMainPassPostProcessing to order against

## Testing

- bloom example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf requested changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InvalidNode(Bloom) crash if bevy_post_process is off
4 participants
@fairhill1 @mockersf @alice-i-cecile @hukasu