Skip to content

Conversation

@newDINO
Copy link
Contributor

@newDINO newDINO commented Nov 18, 2025

Objective

Screen space reflection didn't work for my program, so I tried cloning bevy repo and running the ssr example to see whether it works or not, and it didn't. I figured out that the problem is that prepare_ssr_pipelines system only runs for views with ExtractedAtmosphere. So I removed this filter because it already uses Has<ExtractedAtmosphere>. And the example works afterwards.

I later found that the With<ExtractedAtmosphere> filter is not added to bevy 0.17, so the problem in my own program is not the same as the ssr example. I compared the ssr example and my program and found that I didn't add DefaultOpaqueRendererMethod::deferred() resource. So I added a few docs to state that deferred rendering is not automatically enabled when ssr is added.

Solution

  1. remove With<ExtractedAtmosphere> filter in prepare_ssr_pipelines.
  2. add more documentation.

Testing

I tested the ssr example and atmosphere example and both look fine.

@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Nov 18, 2025
@alice-i-cecile alice-i-cecile added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 18, 2025
@alice-i-cecile alice-i-cecile added this to the 0.17.4 milestone Nov 18, 2025
@dloukadakis dloukadakis added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 18, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 25, 2025
Merged via the queue into bevyengine:main with commit f21114a Nov 25, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants