update runtime-minimal-python312 image for ppc64le #1632

AaruniAggarwal · 2025-08-05T06:29:10Z

This PR adds additional packages in minimal runtime Dockerfile.cpu for ppc64le as pyzmq require them. Without these changes, image is failing to build on ppc64le with following error:

127.3   note: This error originates from a subprocess, and is likely not a problem with pip.
127.3   ERROR: Failed building wheel for pyzmq
127.3 Failed to build pyzmq
127.3 ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (pyzmq)
127.6 Failed to install requirements, dependency 'pyzmq' could not be installed

This change ensures notebook runtime minimal builds are successfull on IBM Power (ppc64le) and it will not impact to x86_64 builds.

Tested on: ppc64le

Able to build runtime-minimal image for python3.12 with these changes.

Summary by CodeRabbit

Chores
- Improved support for additional architectures during installation by updating the package installation logic.

Signed-off-by: AaruniAggarwal <[email protected]>

coderabbitai · 2025-08-05T06:29:16Z

Walkthrough

The conditional logic in the Dockerfile for the minimal UBI9 Python 3.12 runtime has been updated to install additional development packages for both "s390x" and "ppc64le" architectures, instead of only "s390x" as before.

Changes

Cohort / File(s)	Change Summary
Architecture-specific package installation `runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu`	Expanded the conditional installation of development packages to include "ppc64le" alongside "s390x".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

RHOAISTRAT-169: add conditional package install in minimal Dockerfile.cpu for s390x #1132: Also modifies the same Dockerfile.cpu to extend conditional package installation logic for specific architectures.
adding additional packages in minimal Dockerfile.cpu for ppc64le #1175: Updates the minimal Dockerfile.cpu to add "ppc64le" to the conditional logic for development package installation.
ref(Dockerfiles): reduce duplication in runtimes/minimal/ubi9-python-3.11/Dockerfile.cpu package installation #1166: Refactors architecture-specific package installation logic in the same Dockerfile, handling development packages for "s390x".

Suggested labels

lgtm, approved, ok-to-test, size/xs

Suggested reviewers

paulovmr
jiridanek

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e94f5bf and beaca03.

📒 Files selected for processing (1)

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu (1 hunks)

🧰 Additional context used

🧠 Learnings (16)

📓 Common learnings

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1333
File: runtimes/pytorch/ubi9-python-3.12/utils/bootstrapper.py:619-626
Timestamp: 2025-07-08T19:33:14.340Z
Learning: jiridanek requested GitHub issue creation for Python 3.12 version check bug in bootstrapper.py during PR #1333 review. Issue #1348 was created with comprehensive problem description covering version check exclusion affecting all Python 3.12 runtime images, detailed impact analysis of bootstrapper execution failures, clear solution with code examples, affected files list including all 6 runtime bootstrapper copies, acceptance criteria for testing and verification, implementation notes about code duplication and upstream reporting, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Learnt from: grdryn
PR: opendatahub-io/notebooks#1396
File: jupyter/tensorflow/ubi9-python-3.12/Pipfile:13-14
Timestamp: 2025-07-16T00:17:10.313Z
Learning: grdryn corrected CodeRabbit's false assessment about CUDA companion package wheel availability during PR #1396 review. The original analysis incorrectly checked all package releases instead of the specific versions that would be installed with tensorflow[and-cuda]~=2.19.0. The actual versions (nvidia-cudnn-cu12/9.3.0.75, nvidia-cuda-runtime-cu12/12.5.82, nvidia-cublas-cu12/12.5.3.2) do have aarch64 wheels available on PyPI, making the and-cuda extra compatible with arm64 builds.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1320
File: jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda:42-52
Timestamp: 2025-07-09T12:29:56.162Z
Learning: jiridanek requested GitHub issue creation for OpenShift client architecture mapping problem affecting 29 Dockerfiles during PR #1320 review. Issue was created with comprehensive analysis covering all affected files using $(uname -m) returning 'aarch64' but OpenShift mirror expecting 'arm64', systematic solution using BuildKit TARGETARCH mapping with proper amd64→x86_64 and arm64→arm64 conversion, detailed acceptance criteria, and implementation guidance, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/kustomize/base/kustomization.yaml:8-12
Timestamp: 2025-07-08T19:09:48.746Z
Learning: jiridanek requested GitHub issue creation for misleading CUDA prefix in TrustyAI image tags during PR #1306 review, affecting both Python 3.11 and 3.12 versions. Issue #1338 was created with comprehensive problem description covering both affected images, repository pattern analysis comparing correct vs incorrect naming conventions, clear solution with code examples, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1333
File: runtimes/rocm-pytorch/ubi9-python-3.12/de-vendor-torch.sh:9-12
Timestamp: 2025-07-08T19:28:15.791Z
Learning: jiridanek requested GitHub issue creation for runtime detection improvement of Python site-packages paths during PR #1333 review. Issue #1344 was created with comprehensive problem description covering hard-coded path fragility across UBI9 distributions, extensive affected files analysis including 4 de-vendor scripts, 30+ Dockerfiles with chmod operations, and 12+ pip.conf configurations, runtime detection solution using sysconfig module, implementation areas breakdown, benefits analysis, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1333
File: runtimes/rocm-tensorflow/ubi9-python-3.12/Pipfile:13-15
Timestamp: 2025-07-09T08:07:24.937Z
Learning: jiridanek requested GitHub issue creation for tensorflow_rocm Python 3.12 compatibility problem during PR #1333 review. Issue #1354 was successfully created with comprehensive problem description covering missing cp312 wheels causing build failures, three solution options (upstream TensorFlow, Python 3.11 only, custom build), clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-08-01T17:35:29.175Z
Learning: jiridanek requested GitHub issue creation for adding pytorch+llmcompressor images to Makefile build targets during PR #1519 review. Issue #1598 was successfully created with comprehensive problem description covering missing build targets for both jupyter workbench and runtime images, detailed solution with specific Makefile code examples following established patterns, thorough acceptance criteria covering individual targets, BASE_DIRS variable inclusion, and all-images target integration, implementation notes about handling '+' characters in paths, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1396
File: runtimes/tensorflow/ubi9-python-3.12/Dockerfile.cuda:124-127
Timestamp: 2025-07-21T15:06:04.114Z
Learning: jiridanek requested GitHub issue creation for multi-platform dependency locking investigation during PR #1396 review. Issue #1423 was successfully created with comprehensive problem description covering ARM64 wheel availability but being ignored due to AMD64-only dependency locking, root cause analysis of platform-specific pipenv limitations, immediate conditional installation solution, multi-platform locking ecosystem analysis, broader affected areas investigation, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1320
File: jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda:65-66
Timestamp: 2025-07-09T12:31:02.033Z
Learning: jiridanek requested GitHub issue creation for MSSQL repo file hardcoding problem during PR #1320 review. Issue #1363 was created and updated with comprehensive problem description covering hardcoded x86_64 MSSQL repo files breaking multi-architecture builds across 10 affected Dockerfiles (including datascience, CUDA, ROCm, and TrustyAI variants), detailed root cause analysis, three solution options with code examples, clear acceptance criteria for all image types, implementation guidance following established multi-architecture patterns, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Learnt from: atheo89
PR: opendatahub-io/notebooks#1258
File: codeserver/ubi9-python-3.11/Dockerfile.cpu:32-32
Timestamp: 2025-07-07T11:08:48.524Z
Learning: atheo89 requested GitHub issue creation for multi-architecture Dockerfile improvements during PR #1258 review, specifically for enhancing structural consistency across Docker stages, replacing $(uname -m) with ${TARGETARCH} for cross-architecture builds, and adding OCI-compliant metadata labels. Issue #1332 was created with comprehensive problem description, phased implementation approach, detailed acceptance criteria, implementation guidance with code examples, and proper context linking, continuing the established pattern of systematic code quality improvements.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-11T11:54:28.202Z
Learning: In opendatahub-io/notebooks, Python 3.12-based images (e.g., runtime-cuda-pytorch-ubi9-python-3.12) may fail container runtime tests with "libcrypt.so.1 => not found" for MySQL SASL2 plugin libraries if `libxcrypt-compat` is missing. The solution is to install `libxcrypt-compat` in the Dockerfile.

Learnt from: grdryn
PR: opendatahub-io/notebooks#1320
File: rstudio/rhel9-python-3.11/Dockerfile.cuda:34-35
Timestamp: 2025-07-04T10:41:13.061Z
Learning: In the opendatahub-io/notebooks repository, when adapting NVIDIA CUDA Dockerfiles, the project intentionally maintains consistency with upstream NVIDIA patterns even when it might involve potential risks like empty variable expansions in package installation commands. This is considered acceptable because the containers only run on RHEL 9 with known yum/dnf behavior, and upstream consistency is prioritized over defensive coding practices.

Learnt from: grdryn
PR: opendatahub-io/notebooks#1396
File: jupyter/tensorflow/ubi9-python-3.12/Pipfile:13-14
Timestamp: 2025-07-16T00:17:10.313Z
Learning: When checking PyPI wheel availability for aarch64 architecture, the actual wheel filenames use "manylinux2014_aarch64" pattern, not "linux_aarch64". This caused incorrect analysis in PR #1396 where CodeRabbit falsely claimed CUDA companion packages lacked aarch64 wheels when searching with the wrong pattern. The correct approach is to search for "manylinux2014_aarch64" or use a more generic "aarch64" pattern when verifying wheel availability for ARM64 compatibility.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1320
File: jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda:42-52
Timestamp: 2025-07-09T14:02:39.880Z
Learning: grdryn corrected CodeRabbit's false assessment about OpenShift mirror server architecture support during PR #1320 review. The OpenShift mirror server (https://mirror.openshift.com/pub/openshift-v4/) actually supports both aarch64 and arm64 directory structures, making the current code using $(uname -m) work correctly across architectures without modification. This demonstrates the importance of verifying external service capabilities before flagging issues.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1320
File: jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda:42-52
Timestamp: 2025-07-09T14:02:39.880Z
Learning: grdryn corrected CodeRabbit's false assessment about OpenShift mirror server architecture support during PR #1320 review. The OpenShift mirror server (https://mirror.openshift.com/pub/openshift-v4/) actually supports both aarch64 and arm64 directory structures, making the current code using $(uname -m) work correctly across architectures without modification. This demonstrates the importance of verifying external service capabilities before flagging issues.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/Pipfile:13-15
Timestamp: 2025-07-03T07:03:45.020Z
Learning: The Python 3.11 infrastructure for ROCm TensorFlow images in opendatahub-io/notebooks is already properly configured in the Makefile with both BASE_DIRS entries for Pipfile lock renewals and all-images targets for CI builds, requiring only commenting out the corresponding Python 3.12 entries when downgrading due to wheel availability issues.

📚 Learning: atheo89 requested github issue creation for multi-architecture dockerfile improvements during pr #12...

Learnt from: atheo89
PR: opendatahub-io/notebooks#1258
File: codeserver/ubi9-python-3.11/Dockerfile.cpu:32-32
Timestamp: 2025-07-07T11:08:48.524Z
Learning: atheo89 requested GitHub issue creation for multi-architecture Dockerfile improvements during PR #1258 review, specifically for enhancing structural consistency across Docker stages, replacing $(uname -m) with ${TARGETARCH} for cross-architecture builds, and adding OCI-compliant metadata labels. Issue #1332 was created with comprehensive problem description, phased implementation approach, detailed acceptance criteria, implementation guidance with code examples, and proper context linking, continuing the established pattern of systematic code quality improvements.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: in the opendatahub-io/notebooks repository, when adapting nvidia cuda dockerfiles, the project inten...

Learnt from: grdryn
PR: opendatahub-io/notebooks#1320
File: rstudio/rhel9-python-3.11/Dockerfile.cuda:34-35
Timestamp: 2025-07-04T10:41:13.061Z
Learning: In the opendatahub-io/notebooks repository, when adapting NVIDIA CUDA Dockerfiles, the project intentionally maintains consistency with upstream NVIDIA patterns even when it might involve potential risks like empty variable expansions in package installation commands. This is considered acceptable because the containers only run on RHEL 9 with known yum/dnf behavior, and upstream consistency is prioritized over defensive coding practices.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: jiridanek requested github issue creation for runtime detection improvement of python site-packages ...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1333
File: runtimes/rocm-pytorch/ubi9-python-3.12/de-vendor-torch.sh:9-12
Timestamp: 2025-07-08T19:28:15.791Z
Learning: jiridanek requested GitHub issue creation for runtime detection improvement of Python site-packages paths during PR #1333 review. Issue #1344 was created with comprehensive problem description covering hard-coded path fragility across UBI9 distributions, extensive affected files analysis including 4 de-vendor scripts, 30+ Dockerfiles with chmod operations, and 12+ pip.conf configurations, runtime detection solution using sysconfig module, implementation areas breakdown, benefits analysis, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: jiridanek requested github issue creation for openshift client architecture mapping problem affectin...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1320
File: jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda:42-52
Timestamp: 2025-07-09T12:29:56.162Z
Learning: jiridanek requested GitHub issue creation for OpenShift client architecture mapping problem affecting 29 Dockerfiles during PR #1320 review. Issue was created with comprehensive analysis covering all affected files using $(uname -m) returning 'aarch64' but OpenShift mirror expecting 'arm64', systematic solution using BuildKit TARGETARCH mapping with proper amd64→x86_64 and arm64→arm64 conversion, detailed acceptance criteria, and implementation guidance, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: in opendatahub-io/notebooks, python 3.12-based images (e.g., runtime-cuda-pytorch-ubi9-python-3.12) ...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-11T11:54:28.202Z
Learning: In opendatahub-io/notebooks, Python 3.12-based images (e.g., runtime-cuda-pytorch-ubi9-python-3.12) may fail container runtime tests with "libcrypt.so.1 => not found" for MySQL SASL2 plugin libraries if `libxcrypt-compat` is missing. The solution is to install `libxcrypt-compat` in the Dockerfile.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: jiridanek requested github issue creation for runtime detection improvement of python site-packages ...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1333
File: runtimes/rocm-pytorch/ubi9-python-3.12/de-vendor-torch.sh:9-12
Timestamp: 2025-07-08T19:28:15.791Z
Learning: jiridanek requested GitHub issue creation for runtime detection improvement of Python site-packages paths during PR #1333 review. Issue #1340 was created with comprehensive problem description covering hard-coded path fragility across UBI9 distributions, affected files analysis including de-vendor scripts and pip.conf configurations, runtime detection solution using sysconfig module, implementation areas breakdown, benefits analysis, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: jiridanek requested github issue creation for improving fragile sed-based jupyter kernel display_nam...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu:135-136
Timestamp: 2025-07-04T05:52:49.464Z
Learning: jiridanek requested GitHub issue creation for improving fragile sed-based Jupyter kernel display_name modification in jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu during PR #1306 review. Issue #1321 was created with comprehensive problem description covering JSON corruption risks, greedy regex patterns, maintenance burden, and proposed Python-based JSON parsing solution with detailed acceptance criteria, implementation guidance, and proper context linking, continuing the established pattern of systematic code quality improvements.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: jiridanek requested github issue creation for improving architecture detection in buildinputs tool d...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1320
File: scripts/buildinputs/dockerfile.go:35-35
Timestamp: 2025-07-10T15:02:13.228Z
Learning: jiridanek requested GitHub issue creation for improving architecture detection in buildinputs tool during PR #1320 review. The automated issue creation failed despite appearing successful, so comprehensive issue content was provided for manual creation covering qemu-user s390x build failures where runtime.GOARCH returns host architecture instead of target architecture, detailed impact analysis, four solution options (environment variable detection, configuration parameter, platform detection logic, hybrid approach), clear acceptance criteria for multi-architecture support, phased implementation guidance, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: jiridanek requested github issue creation for mssql repo file hardcoding problem during pr #1320 rev...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1320
File: jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda:65-66
Timestamp: 2025-07-09T12:31:02.033Z
Learning: jiridanek requested GitHub issue creation for MSSQL repo file hardcoding problem during PR #1320 review. Issue #1363 was created and updated with comprehensive problem description covering hardcoded x86_64 MSSQL repo files breaking multi-architecture builds across 10 affected Dockerfiles (including datascience, CUDA, ROCm, and TrustyAI variants), detailed root cause analysis, three solution options with code examples, clear acceptance criteria for all image types, implementation guidance following established multi-architecture patterns, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: issue #862 in opendatahub-io/notebooks reveals that the docker image tag length fix from issue #631 ...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-12T20:04:31.021Z
Learning: Issue #862 in opendatahub-io/notebooks reveals that the Docker image tag length fix from issue #631 is mathematically insufficient. While the fix correctly limits branch names to 40 characters, this fails for longer target names like "runtime-minimal-ubi9-python-3.11" (33 chars) which still produces tags exceeding the 128-character Docker limit. The fix needs dynamic calculation based on actual target name length rather than a fixed 40-character assumption.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: grdryn corrected coderabbit's false assessment about openshift mirror server architecture support du...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1320
File: jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda:42-52
Timestamp: 2025-07-09T14:02:39.880Z
Learning: grdryn corrected CodeRabbit's false assessment about OpenShift mirror server architecture support during PR #1320 review. The OpenShift mirror server (https://mirror.openshift.com/pub/openshift-v4/) actually supports both aarch64 and arm64 directory structures, making the current code using $(uname -m) work correctly across architectures without modification. This demonstrates the importance of verifying external service capabilities before flagging issues.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: in the opendatahub-io/notebooks repository, when using multi-architecture dockerfiles with buildkit,...

Learnt from: grdryn
PR: opendatahub-io/notebooks#1320
File: rstudio/rhel9-python-3.11/Dockerfile.cuda:40-42
Timestamp: 2025-07-04T17:08:02.399Z
Learning: In the opendatahub-io/notebooks repository, when using multi-architecture Dockerfiles with BuildKit, the implicit build argument TARGETARCH is automatically available in the global scope for FROM instructions without explicit declaration. However, if TARGETARCH is used within a build stage, it must be declared explicitly within that stage. The current placement pattern (declaring ARG TARGETARCH after FROM instructions that use it) is correct for modern Docker/Podman/Buildah environments and does not require compatibility with older Docker versions.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: in the opendatahub-io/notebooks repository, mssql repo files are named with x86_64 in the filename b...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1320
File: jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda:65-66
Timestamp: 2025-07-09T14:03:17.456Z
Learning: In the opendatahub-io/notebooks repository, MSSQL repo files are named with x86_64 in the filename but the repo content itself is architecture-agnostic. The right RPMs get installed for the right architectures automatically, making the issue a file naming problem rather than a repo content problem.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: jiridanek requested github issue creation for improving architecture detection in buildinputs tool d...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1320
File: scripts/buildinputs/dockerfile.go:35-35
Timestamp: 2025-07-10T15:02:13.228Z
Learning: jiridanek requested GitHub issue creation for improving architecture detection in buildinputs tool during PR #1320 review. Issue #1364 was created with comprehensive problem description covering qemu-user s390x build failures where runtime.GOARCH returns host architecture instead of target architecture, detailed impact analysis, four solution options (environment variable detection, configuration parameter, platform detection logic, hybrid approach), clear acceptance criteria for multi-architecture support, phased implementation guidance, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

📚 Learning: in the opendatahub-io/notebooks repository, mixing centos packages with ubi base images is bad pract...

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1396
File: jupyter/tensorflow/ubi9-python-3.12/Dockerfile.cuda:192-195
Timestamp: 2025-07-18T19:01:39.811Z
Learning: In the opendatahub-io/notebooks repository, mixing CentOS packages with UBI base images is bad practice that removes supportability and creates "Frankenstein" images according to Red Hat guidance. However, using EPEL packages is acceptable, though it may require extra work with AIPCC for internal Red Hat builds. The official reference is at developers.redhat.com/articles/ubi-faq.

Applied to files:

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu

🔇 Additional comments (1)

runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu (1)

15-17: Addition of ppc64le condition LGTM

The extended check correctly enables the extra build-tool chain on Power systems, matching the existing s390x path.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

openshift-ci · 2025-08-05T06:29:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign daniellutz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AaruniAggarwal · 2025-08-05T06:29:46Z

[root@ocpworkload36 notebooks]# docker build -t nb-runtime-minimal-ubi9py312 -f runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu .
[+] Building 160.5s (15/15) FINISHED                                                                                                                                               docker:default
 => [internal] load build definition from Dockerfile.cpu                                                                                                                                     0.0s
 => => transferring dockerfile: 2.60kB                                                                                                                                                       0.0s
 => [internal] load metadata for registry.access.redhat.com/ubi9/python-312:latest                                                                                                           0.8s
 => [internal] load .dockerignore                                                                                                                                                            0.0s
 => => transferring context: 211B                                                                                                                                                            0.0s
 => [base 1/5] FROM registry.access.redhat.com/ubi9/python-312:latest@sha256:95ec8d3ee9f875da011639213fd254256c29bc58861ac0b11f290a291fa04435                                               16.3s
 => => resolve registry.access.redhat.com/ubi9/python-312:latest@sha256:95ec8d3ee9f875da011639213fd254256c29bc58861ac0b11f290a291fa04435                                                     0.0s
 => => sha256:547b4f1ae78c160934f0432978a59114ffa488302e4dce8c0fc71e8f65d517d3 85.37MB / 85.37MB                                                                                             2.7s
 => => sha256:4b351371296d890d642aebede47616743633ea2a80fb8d0376e0de5445dbf5a3 17.96MB / 17.96MB                                                                                             0.7s
 => => sha256:4def761bce337f2ade18147249b5b4a1576e919c25984c3be14619db56d7db94 213.02MB / 213.02MB                                                                                           4.4s
 => => sha256:95ec8d3ee9f875da011639213fd254256c29bc58861ac0b11f290a291fa04435 916B / 916B                                                                                                   0.0s
 => => sha256:559127c860d0af543b9f3a450ec65482a1c2dd5d82f39a78301fb6dd8d114f5d 1.17kB / 1.17kB                                                                                               0.0s
 => => sha256:bf172bb3e44ffad52d0caa643fcf880348987598ef53395c253d091dc67e360f 17.65kB / 17.65kB                                                                                             0.0s
 => => sha256:aaa0f5240193bd1705b1f060d2955e14cfe6a877c9f5745af10c7c0cffe636f5 69.97MB / 69.97MB                                                                                             3.2s
 => => extracting sha256:547b4f1ae78c160934f0432978a59114ffa488302e4dce8c0fc71e8f65d517d3                                                                                                    4.7s
 => => extracting sha256:4b351371296d890d642aebede47616743633ea2a80fb8d0376e0de5445dbf5a3                                                                                                    0.6s
 => => extracting sha256:4def761bce337f2ade18147249b5b4a1576e919c25984c3be14619db56d7db94                                                                                                    5.3s
 => => extracting sha256:aaa0f5240193bd1705b1f060d2955e14cfe6a877c9f5745af10c7c0cffe636f5                                                                                                    2.4s
 => [internal] load build context                                                                                                                                                            0.1s
 => => transferring context: 162.49kB                                                                                                                                                        0.0s
 => [base 2/5] WORKDIR /opt/app-root/bin                                                                                                                                                     2.3s
 => [base 3/5] RUN ARCH=$(uname -m) &&     echo "Detected architecture: $ARCH" &&     PACKAGES="mesa-libGL skopeo" &&     if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then          6.7s
 => [base 4/5] RUN pip install --no-cache-dir -U "micropipenv[toml]"                                                                                                                         1.4s
 => [base 5/5] RUN curl -L https://mirror.openshift.com/pub/openshift-v4/$(uname -m)/clients/ocp/stable/openshift-client-linux.tar.gz         -o /tmp/openshift-client-linux.tar.gz &&       3.6s 
 => [runtime-minimal 1/5] WORKDIR /opt/app-root/bin                                                                                                                                          0.0s 
 => [runtime-minimal 2/5] COPY runtimes/minimal/ubi9-python-3.12/Pipfile.lock ./                                                                                                             0.0s 
 => [runtime-minimal 3/5] COPY runtimes/minimal/ubi9-python-3.12/utils ./utils/                                                                                                              0.0s 
 => [runtime-minimal 4/5] RUN echo "Installing softwares and packages" &&     micropipenv install &&     rm -f ./Pipfile.lock &&     chmod -R g+w /opt/app-root/lib/python3.12/site-packa  122.5s 
 => [runtime-minimal 5/5] WORKDIR /opt/app-root/src                                                                                                                                          0.2s 
 => exporting to image                                                                                                                                                                       2.0s
 => => exporting layers                                                                                                                                                                      2.0s
 => => writing image sha256:92de6f995e31885bd18a0443a9eb4daf5c616eccb7e91212d0c9c8eb6617bf57                                                                                                 0.0s
 => => naming to docker.io/library/nb-runtime-minimal-ubi9py312

wznoinsk · 2025-08-06T20:34:17Z

/retest

jiridanek · 2025-08-07T08:26:24Z

/lgtm

update runtime-minimal-python312 image for ppc64le

beaca03

Signed-off-by: AaruniAggarwal <[email protected]>

openshift-ci bot requested review from caponetto and dibryant August 5, 2025 06:29

openshift-ci bot added the size/xs label Aug 5, 2025

openshift-ci bot added size/xs and removed size/xs labels Aug 5, 2025

AaruniAggarwal mentioned this pull request Aug 5, 2025

update runtime-minimal image for ppc64le red-hat-data-services/notebooks#1330

Closed

atheo89 added the ppc64le label Aug 5, 2025

openshift-ci bot assigned jiridanek Aug 7, 2025

openshift-ci bot added the lgtm label Aug 7, 2025

jiridanek merged commit 476bbcc into opendatahub-io:main Aug 7, 2025
13 of 16 checks passed

AaruniAggarwal mentioned this pull request Aug 11, 2025

updating runtime-minimal konflux image for ppc64le red-hat-data-services/notebooks#1442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update runtime-minimal-python312 image for ppc64le #1632

update runtime-minimal-python312 image for ppc64le #1632

Uh oh!

AaruniAggarwal commented Aug 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 5, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

openshift-ci bot commented Aug 5, 2025

Uh oh!

AaruniAggarwal commented Aug 5, 2025

Uh oh!

wznoinsk commented Aug 6, 2025

Uh oh!

jiridanek commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

update runtime-minimal-python312 image for ppc64le #1632

update runtime-minimal-python312 image for ppc64le #1632

Uh oh!

Conversation

AaruniAggarwal commented Aug 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

openshift-ci bot commented Aug 5, 2025

Uh oh!

AaruniAggarwal commented Aug 5, 2025

Uh oh!

wznoinsk commented Aug 6, 2025

Uh oh!

jiridanek commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

AaruniAggarwal commented Aug 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 5, 2025 •

edited

Loading