Skip to content

[Snippets][CPU][RV64] Enable infrastructure #31787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

[Snippets][CPU][RV64] Enable infrastructure #31787

wants to merge 34 commits into from
+2,048 −76

Conversation

aobolensk
Copy link
Contributor

Details:

  • Enable snippets infrastructure base
  • Enable elementwise add tests

Tickets:

  • N/A

@aobolensk aobolensk changed the title [Snippets][RISCV64] Enable infrastructure [Snippets][RV64] Enable infrastructure Aug 19, 2025
@github-actions github-actions bot added category: CPU OpenVINO CPU plugin category: build OpenVINO cmake script / infra labels Aug 19, 2025
@aobolensk aobolensk changed the title [Snippets][RV64] Enable infrastructure [Snippets][CPU][RV64] Enable infrastructure Aug 19, 2025
@aobolensk aobolensk added the platform: risc-v OpenVINO on RISC-V label Aug 19, 2025
@aobolensk aobolensk force-pushed the snippets-riscv64 branch 2 times, most recently from 80511cd to 5fb12b2 Compare August 19, 2025 10:34
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Aug 19, 2025
@aobolensk aobolensk force-pushed the snippets-riscv64 branch 6 times, most recently from f57cb65 to 45f8a0d Compare September 11, 2025 08:17
@aobolensk aobolensk marked this pull request as ready for review September 11, 2025 11:07
@aobolensk aobolensk requested review from a team as code owners September 11, 2025 11:07
v-Golubev
v-Golubev reviewed Sep 11, 2025
View reviewed changes
Copy link
Contributor

@v-Golubev v-Golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part

src/plugins/intel_cpu/src/transformations/transformation_pipeline.cpp
};
return is_supported(n) || is_supported_with_scalar_inputs(n);
#elif defined(OPENVINO_ARCH_RISCV64)
return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we return is_supported(n) here, and include only Add to the supported list operations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have intentionally postponed tokenization to the next step

src/plugins/intel_cpu/src/nodes/executors/riscv64/subgraph.cpp
m_buffer_scratchpad = allocator(m_internal_buffer_size);
}

void SubgraphStaticExecutor::exec_impl(const std::vector<MemoryPtr>& inMemPtrs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exec_impl for SubgraphStaticExecutor and SubgraphDynamicSpecializedExecutor are exactly the same as for ARM64. We should definitely think how to unify this code

@aobolensk aobolensk force-pushed the snippets-riscv64 branch 2 times, most recently from c4a1f8e to 4bff223 Compare September 15, 2025 08:40
@aobolensk aobolensk force-pushed the snippets-riscv64 branch 2 times, most recently from 9bcee7e to c77aea3 Compare September 15, 2025 09:23
@aobolensk aobolensk force-pushed the snippets-riscv64 branch 3 times, most recently from d70d368 to 8947192 Compare September 22, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-Golubev v-Golubev v-Golubev left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@v-Golubev v-Golubev

Labels
category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: CPU OpenVINO CPU plugin github_actions Pull requests that update GitHub Actions code platform: risc-v OpenVINO on RISC-V
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aobolensk @v-Golubev