fix(setup): Improve yq installation and handling #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeRepko
force-pushed
the
hcsfix
branch
3 times, most recently
from
6ddc9ad to
9565999
Compare
LukeRepko
changed the title
LukeRepko
force-pushed
the
hcsfix
branch
5 times, most recently
from
def76c3 to
0b624b8
Compare
Add verbosity to the wget command so we can troubleshoot download failures if encountered more easily, as well as very clear and concise messaging around whether or not yq really got installed. YQ is more necessary on the remote host than the local host that runs the hyperconverged-lab script, so warn about it not getting installed locally but fail if not present on the remote host as it's a pre-requisite to running many install scripts.
Troubleshooting the lab build failures, post setup is being executed within seconds after the nova install completes, which may be too fast. If I can confirm it's a race condition, we will want a more intelligent way to determine when cluster is ready before proceeding to post-setup. For now, just adding dumb retry logic to the openstack commands to see if that helps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add verbosity to the wget command so we can troubleshoot download failures if encountered more easily, as well as clear and concise messaging around whether or not yq really got installed.
YQ is more necessary on the remote host than the local host that runs the hyperconverged-lab script, so warn about it not getting installed locally but fail if not present on the remote host as it's a prerequisite to running many install scripts.