chore: add Linux ARM64 and Windows build targets #2551
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 5, 2025
Deploying rivet with
|
| Latest commit: |
92edf66
|
| Status: | 🚫 Build failed. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added support for Linux ARM64 and Windows build targets with multi-architecture Dockerfile restructuring and release workflow modifications.
- Separated architecture-specific Dockerfiles for Linux (x86_64/aarch64) and macOS (x86_64/aarch64) in
/docker/toolchain/ - Added Windows build target support in
/docker/toolchain/build.shwith.exefile handling - Fixed issue with duplicate
rivetgg/server:slimbuild step in/.github/workflows/release.yaml - Configured OpenSSL 1.1.1w builds for each architecture with appropriate target-specific settings
- Potential issue: Windows target incorrectly specified as
x86_64-pc-windows-muslinstead of GNU/MSVC
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| ENV PATH="/root/osxcross/target/bin:$PATH" | ||
|
|
||
| # Common environment variables for cross-compilation | ||
| ENV MACOSX_DEPLOYMENT_TARGET=10.7 \ |
There was a problem hiding this comment.
logic: MACOSX_DEPLOYMENT_TARGET=10.7 is very old and may not be appropriate for ARM64 builds which started with macOS 11.0
Suggested change
| ENV MACOSX_DEPLOYMENT_TARGET=10.7 \ | |
| ENV MACOSX_DEPLOYMENT_TARGET=11.0 \ |
NathanFlurry
force-pushed
the
chore_add_Linux_ARM64_and_Windows_build_targets
branch
2 times, most recently
from
441f4f4 to
fa06adb
Compare
NathanFlurry
force-pushed
the
fix_uncomment_function_type_filter_in_ACTORS_FILTER
branch
from
e90af51 to
fba55a4
Compare
NathanFlurry
force-pushed
the
fix_uncomment_function_type_filter_in_ACTORS_FILTER
branch
from
fba55a4 to
d8521b4
Compare
NathanFlurry
force-pushed
the
chore_add_Linux_ARM64_and_Windows_build_targets
branch
from
fa06adb to
c360977
Compare
Deploying rivet-studio with
|
| Latest commit: |
74a37d2
|
| Status: | ⚡️ Build in progress... |
Deploying rivet-hub with
|
| Latest commit: |
92edf66
|
| Status: | 🚫 Build failed. |
NathanFlurry
changed the base branch from
fix_uncomment_function_type_filter_in_ACTORS_FILTER
to
graphite-base/2551
MasterPtato
changed the base branch from
graphite-base/2551
to
fix_uncomment_function_type_filter_in_ACTORS_FILTER
NathanFlurry
force-pushed
the
fix_uncomment_function_type_filter_in_ACTORS_FILTER
branch
from
d8521b4 to
b7c38f4
Compare
NathanFlurry
force-pushed
the
chore_add_Linux_ARM64_and_Windows_build_targets
branch
from
c360977 to
62fd12b
Compare
MasterPtato
force-pushed
the
fix_uncomment_function_type_filter_in_ACTORS_FILTER
branch
from
b7c38f4 to
65e7c70
Compare
MasterPtato
force-pushed
the
chore_add_Linux_ARM64_and_Windows_build_targets
branch
from
62fd12b to
6f45f25
Compare
This was referenced Jun 9, 2025
Closed
This was referenced Jun 16, 2025
MasterPtato
force-pushed
the
chore_add_Linux_ARM64_and_Windows_build_targets
branch
from
e36ca13 to
92edf66
Compare
This was referenced Jun 17, 2025
abcxff
force-pushed
the
fix_uncomment_function_type_filter_in_ACTORS_FILTER
branch
from
127da0d to
da02915
Compare
abcxff
force-pushed
the
chore_add_Linux_ARM64_and_Windows_build_targets
branch
from
92edf66 to
1614ba1
Compare
MasterPtato
force-pushed
the
chore_add_Linux_ARM64_and_Windows_build_targets
branch
from
1614ba1 to
92edf66
Compare
MasterPtato
force-pushed
the
fix_uncomment_function_type_filter_in_ACTORS_FILTER
branch
from
da02915 to
127da0d
Compare
This was referenced Jun 19, 2025
NathanFlurry
force-pushed
the
fix_uncomment_function_type_filter_in_ACTORS_FILTER
branch
from
127da0d to
dd008fa
Compare
NathanFlurry
force-pushed
the
chore_add_Linux_ARM64_and_Windows_build_targets
branch
from
92edf66 to
74a37d2
Compare
This was referenced Jun 20, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
chore_add_Linux_ARM64_and_Windows_build_targets
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes