feat: add non-interactive mode and route management options to CLI #2532

NathanFlurry · 2025-06-04T08:43:19Z

Changes

NathanFlurry · 2025-06-04T08:43:34Z

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

This PR adds non-interactive mode and route management options to the Rivet CLI, enabling automated deployments and fine-grained control over route handling.

Added skip_route_creation and keep_existing_routes options in deploy.rs to control route behavior, but these are not properly exposed in actor/create.rs
New function module with list and endpoint commands for route management, but endpoint.rs has potential issues with route ID vs function name matching
Modified setup_function_routes in deploy.rs to support non-interactive mode with detailed logging, but could benefit from more robust error handling
Added environment credential persistence in toolchain_ctx.rs when loading from env vars
Inconsistent naming between 'function' and 'route' throughout the codebase (e.g., command aliases) could cause confusion

_{8 file(s) reviewed, 10 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-06-04T08:44:09Z

packages/toolchain/cli/src/commands/deploy.rs

+	#[clap(long)]
+	skip_route_creation: Option<bool>,


style: Missing help text for skip_route_creation option. Add doc comment explaining what this flag does.

greptile-apps · 2025-06-04T08:44:10Z

packages/toolchain/cli/src/commands/deploy.rs

+	#[clap(long)]
+	keep_existing_routes: Option<bool>,


style: Missing help text for keep_existing_routes option. Add doc comment explaining what this flag does.

greptile-apps · 2025-06-04T08:44:10Z

packages/toolchain/cli/src/commands/function/list.rs

+/// List all functions for an environment
+#[derive(Parser)]
+pub struct Opts {
+	/// Specify the environment to list function for (will prompt if not specified)


syntax: Typo in help text: 'list function for' should be 'list functions for'

Suggested change

/// Specify the environment to list function for (will prompt if not specified)

/// Specify the environment to list functions for (will prompt if not specified)

greptile-apps · 2025-06-04T08:44:11Z

packages/toolchain/cli/src/commands/actor/create.rs

+				skip_route_creation: None,
+				keep_existing_routes: None,
+				non_interactive: false,


logic: These new deploy options are hardcoded but not exposed in the actor creation CLI. Should add corresponding CLI options if these parameters are meant to be configurable.

greptile-apps · 2025-06-04T08:44:13Z

packages/toolchain/cli/src/commands/function/endpoint.rs

+async fn get_route(
+	ctx: &ToolchainCtx,
+	env: &str,
+	route_id: &str,


style: Parameter name route_id is misleading since it's actually receiving a function name

Suggested change

route_id: &str,

function_name: &str,

greptile-apps · 2025-06-04T08:44:14Z

packages/toolchain/cli/src/commands/function/endpoint.rs

+	let matching_route = routes_response
+		.routes
+		.iter()
+		.find(|route| route.id == *route_id)


logic: Route lookup compares route.id with route_id but receives a function name - these may not match. Should likely compare against a different route field

greptile-apps · 2025-06-04T08:44:35Z

packages/toolchain/cli/src/commands/function/mod.rs

+pub mod endpoint;
+pub mod list;
+
+/// Commands for managing routes


style: Module comment describes 'routes' but module name is 'function'. Consider updating comment or module name for consistency.

greptile-apps · 2025-06-04T08:44:41Z

packages/toolchain/cli/src/commands/mod.rs

+	/// Commands for managing routes
+	#[clap(alias = "f", alias = "func", alias = "route")]
+	Function {
+		#[clap(subcommand)]
+		subcommand: function::SubCommand,
+	},


style: The docstring says 'Commands for managing routes' but the command is named 'Function'. Consider renaming to 'Route' for consistency with the documentation, or update the docstring to match the command name.

greptile-apps · 2025-06-04T08:44:42Z

packages/toolchain/cli/src/commands/mod.rs

+	/// Get information about a specific route endpoint
+	Endpoint(function::endpoint::Opts),


logic: The Endpoint command appears to duplicate functionality that should be under the Function subcommand. Consider moving this under Function instead of having it as a top-level command.

greptile-apps · 2025-06-04T08:44:47Z

packages/toolchain/cli/src/util/deploy.rs

+	pub skip_route_creation: Option<bool>,
+	pub keep_existing_routes: Option<bool>,
+	pub non_interactive: bool,


style: Consider making skip_route_creation and keep_existing_routes required bools when non_interactive is true

cloudflare-workers-and-pages · 2025-06-04T08:55:46Z

Deploying rivet-studio with Cloudflare Pages

Latest commit:	`98c7762`
Status:	⚡️ Build in progress...

View logs

cloudflare-workers-and-pages · 2025-06-04T08:56:06Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`3cd15b1`
Status:	✅ Deploy successful!
Preview URL:	https://5cb2ba00.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://feat-add-non-interactive-mod.rivet-hub-7jb.pages.dev

View logs

cloudflare-workers-and-pages · 2025-06-04T08:56:12Z

Deploying rivet with Cloudflare Pages

Latest commit:	`98c7762`
Status:	✅ Deploy successful!
Preview URL:	https://c834f55d.rivet.pages.dev
Branch Preview URL:	https://feat-add-non-interactive-mod.rivet.pages.dev

View logs

graphite-app · 2025-06-20T19:02:41Z

Merge activity

Jun 20, 7:02 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
Jun 20, 7:03 PM UTC: CI is running for this pull request on a draft pull request (#2629) due to your merge queue CI optimization settings.
Jun 20, 7:04 PM UTC: Merged by the Graphite merge queue via draft PR: #2629.

…2532)  ## Changes

NathanFlurry mentioned this pull request Jun 4, 2025

chore(examples): multitenant deploys example #2527

Closed

greptile-apps bot reviewed Jun 4, 2025

View reviewed changes

NathanFlurry force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from 66e1fea to 9a6121a Compare June 4, 2025 08:52

NathanFlurry mentioned this pull request Jun 4, 2025

fix: uncomment function type filter in ACTORS_FILTER #2533

Closed

NathanFlurry force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from 9a6121a to 8dd2e07 Compare June 5, 2025 01:36

NathanFlurry mentioned this pull request Jun 5, 2025

chore: add Linux ARM64 and Windows build targets #2551

Closed

NathanFlurry force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from 8dd2e07 to 599e320 Compare June 5, 2025 04:45

NathanFlurry mentioned this pull request Jun 5, 2025

feat: implement clickhouse-user-query #2554

Closed

NathanFlurry force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from 599e320 to 6f9b0ac Compare June 8, 2025 19:09

This was referenced Jun 8, 2025

fix(toolchain): fix compat with deploying using podman #2571

Closed

fix(pegboard): fix enabling root users #2572

Closed

NathanFlurry force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from 6f9b0ac to e336e8e Compare June 9, 2025 18:59

MasterPtato changed the base branch from main to graphite-base/2532 June 9, 2025 19:25

MasterPtato force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from e336e8e to 571ab68 Compare June 9, 2025 19:26

MasterPtato changed the base branch from graphite-base/2532 to 06-09-fix_pegboard_fix_container_runner_orphaning June 9, 2025 19:26

This was referenced Jun 16, 2025

fix(toolchain): creating ci env no longer fails first try #2618

Closed

feat(examples): multitenant using remote builds #2619

Closed

MasterPtato force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from 259d912 to 540f9d2 Compare June 16, 2025 21:56

This was referenced Jun 16, 2025

fix: add cache to server list queries #2620

Closed

fix: make service discovery use a single client #2621

Closed

MasterPtato force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from 540f9d2 to 3cd15b1 Compare June 17, 2025 00:33

abcxff force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from 3cd15b1 to 259d912 Compare June 18, 2025 16:37

MasterPtato force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from 259d912 to 3cd15b1 Compare June 18, 2025 23:47

This was referenced Jun 19, 2025

fix: figure out actor log shipping #2622

Closed

fix: get new actors working on docker compose #2623

Closed

NathanFlurry force-pushed the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch from 3cd15b1 to 98c7762 Compare June 20, 2025 18:54

graphite-app bot closed this Jun 20, 2025

graphite-app bot deleted the feat_add_non-interactive_mode_and_route_management_options_to_CLI branch June 20, 2025 19:04

github-actions bot mentioned this pull request Jun 20, 2025

chore(main): release 25.5.1 #2423

Merged

NathanFlurry mentioned this pull request Jul 3, 2025

chore: cargo fmt #2710

Closed

	/// Specify the environment to list function for (will prompt if not specified)
	/// Specify the environment to list functions for (will prompt if not specified)

		/// Get information about a specific route endpoint
		Endpoint(function::endpoint::Opts),

feat: add non-interactive mode and route management options to CLI #2532

feat: add non-interactive mode and route management options to CLI #2532

Uh oh!

Conversation

NathanFlurry commented Jun 4, 2025

Changes

Uh oh!

NathanFlurry commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-studio with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-hub with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

graphite-app bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

NathanFlurry commented Jun 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 4, 2025 •

edited

Loading

graphite-app bot commented Jun 20, 2025 •

edited

Loading