fix(guard): add more tokio runtime metrics, remove labels from metrics

[MasterPtato]

Changes

[MasterPtato]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat: db sh for workflows #2570
• fix(pegboard): fix enabling root users #2572
• fix(toolchain): fix compat with deploying using podman #2571
• feat: implement clickhouse-user-query #2554
• chore: add Linux ARM64 and Windows build targets #2551
• fix: uncomment function type filter in ACTORS_FILTER #2533
• chore(examples): multitenant deploys example #2527
• feat: add non-interactive mode and route management options to CLI #2532
• fix(pegboard): fix container runner orphaning #2575
• fix: dont include installing servers in service discovery #2569
• fix(pegboard): fix allocation metrics #2568
• fix: fix edge dc eligible calculation #2567
• fix(cluster): fix scaling logic and dedup metrics #2566
• feat(pegboard): add draining state to alloc metrics #2565
• fix(guard): dont route to installing api nodes #2564
• fix: improve error handling in status check #2563
• fix: add vector http config to edge configs #2553
• chore: fix dc wf #2552
• chore(vector): add vector pipeline to ship clickhouse events from the edge #2526
• fix(pegboard): increase actor log ttl to 14 days #2544
• feat(clusters): add margin per pool #2543
• Fix(guard): return error response on router error #2540
• fix(pegboard): wait for actor allocation not creation #2539
• fix(pegboard): increase signal timeout, add check for actor exit #2538
• fix(pegboard): revise actor rescheduling algorithm, add client metrics #2531
• fix: fix build cache key #2530
• feat: add retries to sql macros #2529
• fix: add create ts to server list #2523
• fix: fix pb metrics standalone #2518
• chore: disable OTEL by default in guard service #2522
• chore: increase file watch limit for rivet guard #2521
• fix(pegboard): continue exporting metrics even if fetching actor fails #2520
• fix(pegboard): fix collecting metrics for actors without workflows #2519
• feat(guard): add http ping endpoint to edge api hosts #2506
• chore: update workspace #2505
• chore: fix guard metrics #2504
• feat: add pb usage metrics, server state #2503
• fix(cache): add traces #2489
• fix(guard): add more tokio runtime metrics, remove labels from metrics #2485 👈 (View in Graphite)
• fix(guard): replace internal caches with moka #2481
• fix(guard): add metrics #2480
• chore: expose namespace in otel attributes #2501 : 1 other dependent PR (#2502 )
• chore: add standalone toolchain build scripts #2400 : 1 other dependent PR (#2500 )
• refactor: replace unsafe File::from_raw_fd with safe File::from #2479
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

PR Summary

This PR enhances Tokio runtime observability while simplifying guard service metrics to reduce cardinality.

• Added TOKIO_TASK_TOTAL and TOKIO_ACTIVE_TASK_COUNT metrics in packages/common/runtime/src/metrics.rs for tracking task lifecycle
• Removed actor_id, server_id, method, and path labels from PROXY_REQUEST_TOTAL and PROXY_REQUEST_PENDING in packages/edge/infra/guard/core/src/metrics.rs
• Simplified PROXY_REQUEST_DURATION to only track status label
• Added error tracking via PROXY_REQUEST_ERROR with error_type label
• Configured Tokio runtime builder to collect new task metrics in packages/common/runtime/src/lib.rs

_{4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

style: Consider using structured error types instead of error.to_string() to avoid high cardinality in error labels

[greptile-apps]

logic: Metrics incremented before error handling - could lead to inaccurate counts if subsequent operations fail

[cloudflare-workers-and-pages]

Deploying rivet with    Cloudflare Pages

Latest commit:	0bf9b0a
Status:	✅  Deploy successful!
Preview URL:	https://f83682c1.rivet.pages.dev
Branch Preview URL:	https://05-28-fix-guard-add-more-tok.rivet.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying rivet-studio with    Cloudflare Pages

Latest commit:	0bf9b0a
Status:	✅  Deploy successful!
Preview URL:	https://9b699cf3.rivet-studio.pages.dev
Branch Preview URL:	https://05-28-fix-guard-add-more-tok.rivet-studio.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying rivet-hub with    Cloudflare Pages

Latest commit:	0bf9b0a
Status:	✅  Deploy successful!
Preview URL:	https://255bbf9c.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://05-28-fix-guard-add-more-tok.rivet-hub-7jb.pages.dev

View logs