-
Notifications
You must be signed in to change notification settings - Fork 216
Introducing a Stripe order helper class #4613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mayisha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far. Noticed a couple of issues while going through the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this Wesley! New changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. LGTM 👍
✅ Code looks good.
✅ Tests are passing.
✅ Settings page looks good.
✅ Checkout page looks good.
✅ Payment with card successful (block and classic checkout)
✅ Payment with iDeal
✅ Refund
See peNR48-1Jc-p2
Changes proposed in this Pull Request:
This PR introduces a new helper class to handle order-specific data within the extension. This is related to the previous attempt to add an order model class, which we reverted due to incompatibility.
Instead of a model, this new class will retrieve and update
WC_Orderdata (from existing instances), so we should not encounter instantiation issues.In this first part, I am adding some querying methods and some flags. In the second part, I will add most of the getters and setters.
Testing instructions
Changelog entry
Changelog Entry Comment
Comment
Post merge