Skip to content

Conversation

@wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Aug 21, 2025

See peNR48-1Jc-p2

Changes proposed in this Pull Request:

This PR introduces a new helper class to handle order-specific data within the extension. This is related to the previous attempt to add an order model class, which we reverted due to incompatibility.

Instead of a model, this new class will retrieve and update WC_Order data (from existing instances), so we should not encounter instantiation issues.

In this first part, I am adding some querying methods and some flags. In the second part, I will add most of the getters and setters.

Testing instructions

  • Code review
  • Check if the tests are still passing
  • Perform some basic smoke testing to confirm no regression was introduced

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Aug 21, 2025
@wjrosa wjrosa marked this pull request as ready for review August 21, 2025 23:22
@wjrosa wjrosa added this to the 9.9.0 milestone Aug 21, 2025
@wjrosa wjrosa modified the milestones: 9.9.0, 10.0.0 Aug 22, 2025
@wjrosa wjrosa marked this pull request as draft August 22, 2025 18:03
Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far. Noticed a couple of issues while going through the changes.

@wjrosa wjrosa requested review from Mayisha and malithsen September 18, 2025 11:51
Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Wesley! New changes look good to me.

Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. LGTM 👍

✅ Code looks good.
✅ Tests are passing.
✅ Settings page looks good.
✅ Checkout page looks good.
✅ Payment with card successful (block and classic checkout)
✅ Payment with iDeal
✅ Refund

@wjrosa wjrosa enabled auto-merge (squash) September 23, 2025 13:32
@wjrosa wjrosa merged commit 759b516 into develop Sep 23, 2025
40 checks passed
@wjrosa wjrosa deleted the dev/order-helper-class branch September 23, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants