cbe: fix more MIPS register names in inline assembly #25695
+21
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtexx
changed the title
alexrp
reviewed
Oct 25, 2025
Comment on lines
+5776
to
+5795
| if (name[0] == 'r') { | ||
| // C uses "$N" for register names instead of "rN" used by Zig. | ||
| var c_name_buf: [4]u8 = undefined; | ||
| const c_name = (&c_name_buf)[0..name.len]; | ||
| @memcpy(c_name, name); | ||
| c_name_buf[0] = '$'; | ||
|
|
||
| try w.print(" {f}", .{fmtStringLiteral(c_name, null)}); | ||
| (try w.writableArray(1))[0] = ','; | ||
| continue; | ||
| } else if (mem.startsWith(u8, name, "fcc") or name[0] == 'w' or name[0] == 'f') { | ||
| // C requires a "$" prefix before register names. | ||
| var c_name_buf: [6]u8 = undefined; | ||
| c_name_buf[0] = '$'; | ||
| @memcpy((&c_name_buf)[1..][0..name.len], name); | ||
|
|
||
| try w.print(" {f}", .{fmtStringLiteral((&c_name_buf)[0 .. 1 + name.len], null)}); | ||
| (try w.writableArray(1))[0] = ','; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Some of my recent work led me to the realization that Alpha also uses $-prefixed registers... so we'll need this code for more targets.
To make it a bit more maintainable, I would suggest moving c_name_buf out of the target check and just giving it a "big enough" size like 64, renaming name to field_name, and then:
const name = if (target.cpu.arch.isMIPS())
// ... write into c_name_buf and return a slice of it ...
else
field_name;Then we also don't need to duplicate the trailing writing logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang crashes when I write "$w0" in clobbers (: