-
Notifications
You must be signed in to change notification settings - Fork 61
Game Piece Asset Support [AARD-1902]
#1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…todesk/synthesis into colbura/1902/game-piece-asset-support
…/game-piece-asset-support
…/game-piece-asset-support
…/game-piece-asset-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are currently failing, looks like it might be similar to #1222 but want to confirm.
@BrandonPacewic @azaleacolburn this PR just requires merge conflicts resolution, correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking into the tests I think this is a separate issue and one that is introduced by this PR. Please take a look.
…/game-piece-asset-support
let rn: RigidNode | null = null | ||
rg.occurrences!.forEach(y => { | ||
rg.occurrences!.reduce<RigidNode | null>((rn, y) => { | ||
const currentRn = this._partToNodeMap.get(y)! | ||
|
||
rn = !rn ? currentRn : currentRn.id != rn.id ? this.mergeRigidNodes(currentRn, rn) : rn | ||
}) | ||
return !rn ? currentRn : currentRn.id != rn.id ? this.mergeRigidNodes(currentRn, rn) : rn | ||
}, null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was also a refactor
3ea97cb
to
d51c833
Compare
…/game-piece-asset-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I click on Configure Assets
and go to the Pieces
tab all I see is the current field. If I select it I don't see any other options:

When spawning fields the game pieces don't appear to be aligned properly. I remember this coming up in discussions at one point but I don't remember what the conclusion of it was.

This issue is caused by the transform on the part instance being miscalculated in the exporter. This wasn't an issue before since we used the field rigid node rather than the independent part transform. The pieces aren't off by a consistent amount across fields, so here's what I'm going to do:
|
…/game-piece-asset-support
…/game-piece-asset-support
Description
Game pieces are now treated as separate assets from the field, they are able to be spawned, deleted, cached, etc, all on their own.
Objectives
Testing Done
Note
Fields no longer spawn with a transform gizmo attached
AARD-1902