Patched DF 49.0.2 (take 1) #73
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
) Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.19 to 0.3.20. - [Release notes](https://github.com/tokio-rs/tracing/releases) - [Commits](tokio-rs/tracing@tracing-subscriber-0.3.19...tracing-subscriber-0.3.20) --- updated-dependencies: - dependency-name: tracing-subscriber dependency-version: 0.3.20 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rceDistribution) which later causes an error during EnforceSort (without our patch). The next DataFusion version 46 upgrade does the proper fix, which is to not insert the coalesce in the first place. test: recreating the iox plan: * demonstrate the insertion of coalesce after the use of column estimates, and the removal of the test scenario's forcing of rr repartitioning test: reproducer of SanityCheck failure after EnforceSorting removes the coalesce added in the EnforceDistribution fix: special case to not remove the needed coalesce
…pache#17003) * Support centroids config for `approx_percentile_cont_with_weight` * Match two functions' signature * Update docs * Address comments and unify centroids config
…ntile_cont_with_weight` (apache#16999) * Add sqllogictests * Allow both new and old sytanx for approx_percentile_cont and approx_percentile_cont_with_weight * Update docs * Add documentation and more tests
* feat: support distinct for window * fix * fix * fisx * fix unparse * fix test * fix test * easy way * add test * add comments
crepererum
force-pushed
the
upgrade-df-ver4902-a
branch
from
024a7c9 to
f189789
Compare
…he#17404) * test: regression test for apache#17372 * test: add more direct regression for apache#17372 * fix: return ALL constants in `EquivalenceProperties::constants`
|
I changed the title to "take 2" as I think this is the second attempt |
…he#17431) * feat: Support binary data types for `SortMergeJoin` `on` clause * Add sql level tests for merge join on binary keys --------- Co-authored-by: Andrew Lamb <[email protected]>
No, it's take 1 for 49.0.2 (the earlier attempt was for 49.0.1). |
I did some research, and I think this ticket describes our current issues: I have put it into the backlog for consideration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: https://github.com/influxdata/influxdb_iox/issues/14924
Patches
Patches map to commits 1:1 (i.e. every patch is exactly 1 commit) and are ordered for easier correlation of the description and the respective commits. They are also grouped in 3 stages.
A: Dummy
No actual patches, can be dropped at any point:
B: CI Fixes
Need to get CI up and running before picking any actual patches:
chore(deps): bump tracing-subscriber from 0.3.19 to 0.3.20:That's chore(deps): bump tracing-subscriber from 0.3.19 to 0.3.20 apache/datafusion#17355 . Without it, the "security audit" CI check fails because it finds an issue in the
Cargo.lockfile used for the examples. This wouldn't affect us, but it's easier to reason about a green CI. Can be dropped with DF 50.All commits afterwards should build cleanly!
C: Patches
These are the actual relevant patches:
chore: default=true for skip_physical_aggregate_schema_check, and add warn logging:until we chase down all warnings in our iox logs (see https://github.com/influxdata/influxdb_iox/issues/12404 )
fix: temporary fix to handle incorrect coalesce (inserted during EnforceDistribution) which later causes an error during EnforceSort (without our patch). The next DataFusion version 46 upgrade does the proper fix, which is to not insert the coalesce in the first place.:There is EAR-5822 (also see https://github.com/influxdata/influxdb_iox/issues/13310 ) despite what the note in Patched DataFusion version
45.0.0#54 and ParallelizeSorts, a subrule of EnforceSorting optimizer, should not remove necessary coalesce. apache/datafusion#14691 (comment) say, this is still required for DF version 46. Otherwise the regression test fails. Also see this slack thread.fix(build-wasm): put arrow-ipc/zstd dep under compression feature flag:That's fix(build-wasm): put
arrow-ipc/zstddep undercompressionfeature apache/datafusion#16844. I need this for https://github.com/influxdata/datafusion-udf-wasm . Can be dropped with DF 50.Support centroids config for approx_percentile_cont_with_weight:That's Support
centroidsconfig forapprox_percentile_cont_with_weightapache/datafusion#17003 . Needed so that the next patch applies cleanly. Can be dropped with DF 50.(Re)Support old syntax for approx_percentile_cont and approx_percentile_cont_with_weight:That's (Re)Support old syntax for
approx_percentile_contandapprox_percentile_cont_with_weightapache/datafusion#16999 . Can be dropped with DF 50.feat: support distinct for window:That's feat: support distinct for window apache/datafusion#16925 because a customer wants it (see https://github.com/influxdata/EAR/issues/6252 ). Can be dropped with DF 50.
fix: return ALL constants in EquivalenceProperties::constants:That's fix: return ALL constants in
EquivalenceProperties::constantsapache/datafusion#17404 . This was a regression in DF 49 that tripped our query tests. Can be dropped with DF 50.feat: Support binary data types for SortMergeJoin on clause:That's feat: Support binary data types for
SortMergeJoinonclause apache/datafusion#17431 backported. Can be dropped with DF 50.chore: skip order calculation / exponential planning:Even though we initially thought that this is no longer required with DF 49, it still is. Otherwise we run into https://github.com/influxdata/influxdb_iox/issues/13038 and the regression test
end_to_end_cases::querier::influxrpc::read_filter::read_filter_many_tableswill fail.(New) Test + workaround for SanityCheck plan:This is required because the previous patch (:top:) trips the sanity checker. Note though that the original commit b41808b once contained a test which no longer seem to trigger a sanity check error w/o the patch, so the test is kinda useless and was dropped.