-
Notifications
You must be signed in to change notification settings - Fork 320
Add a MapboxTripStarter #6794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a MapboxTripStarter #6794
Conversation
0346529
to
2071fe8
Compare
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarterExtra.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Outdated
Show resolved
Hide resolved
...n/java/com/mapbox/navigation/ui/app/internal/controller/TripSessionStarterStateController.kt
Outdated
Show resolved
Hide resolved
...-dropin/src/main/java/com/mapbox/navigation/dropin/permission/LocationPermissionComponent.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Outdated
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/tripsession/TripSessionComponent.kt
Show resolved
Hide resolved
libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/tripsession/TripSessionComponent.kt
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #6794 +/- ##
============================================
- Coverage 72.65% 72.63% -0.03%
- Complexity 5564 5567 +3
============================================
Files 781 780 -1
Lines 30132 30115 -17
Branches 3565 3561 -4
============================================
- Hits 21893 21873 -20
- Misses 6810 6817 +7
+ Partials 1429 1425 -4
|
I'm moving this one back to draft because there are issues that need to be resolved. I would also like to rebase on top of this one because that should simplify the issues #6817 EDIT: Ok this has been rebased, updated, and there's an example to test. It also fixes the DropInUi voice instruction orientation change issue. Please take a look at |
d624f7e
to
add2cd4
Compare
ChangelogFeatures
Bug fixes and improvements
Known issues
|
qa-test-app/src/main/java/com/mapbox/navigation/qa_test_app/view/RoadObjectsActivity.kt
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Outdated
Show resolved
Hide resolved
...-dropin/src/main/java/com/mapbox/navigation/dropin/permission/LocationPermissionComponent.kt
Outdated
Show resolved
Hide resolved
11da227
to
74c3dcf
Compare
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Show resolved
Hide resolved
d63c52f
to
3b785e4
Compare
...tion-core/src/main/java/com/mapbox/navigation/core/trip/session/TripSessionLocationEngine.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarterOptions.kt
Outdated
Show resolved
Hide resolved
qa-test-app/src/main/java/com/mapbox/navigation/qa_test_app/view/RoadObjectsActivity.kt
Show resolved
Hide resolved
libnavigation-core/src/test/java/com/mapbox/navigation/core/trip/MapboxTripStarterTest.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/test/java/com/mapbox/navigation/core/trip/MapboxTripStarterTest.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarterOptions.kt
Outdated
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/MapboxTripStarter.kt
Show resolved
Hide resolved
64365df
to
0300a78
Compare
80c9abd
to
8d027f7
Compare
|
Oh, that's not good... I haven't seen it fail lately. But I don't think it's related to your PR, I'll look at the logs. |
Description
https://mapbox.atlassian.net/browse/NAVAND-652
Right now it is difficult to enable/disable replay with AA and DropInUi because the two systems have different lifecycles. For example, DropInUi can be started and it will start replay with the
TripSessionComponent
. When DropInUi is closed, it will detach theTripSessionComponent
. Considering that, the car head unit is expected to work when the mobile app is closed - it is expected that the car head unit can continue to use a replay session created by the mobile app. We don't have a solution solution for this yet.The issue is being resolved by this pull request. With the new
MapboxTripStarter
used by DropInUi, after an SDK release we can use theMapboxTripStarter
in theandroid-auto-app
and the instance will be shared between the two systems. It will not matter if the car or app was launched first. This will also give us the ability to control the replay state from the car or app.