fix: fix pb metrics standalone #2518
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2025
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes the pegboard metrics standalone service by switching database implementations and improving error handling. The changes primarily focus on metrics collection and storage reliability.
- Switches from CockroachDB to FoundationDB+SQLite in
packages/edge/services/pegboard/standalone/usage-metrics-publish/src/lib.rsfor actor data storage - Adds improved error handling in
packages/edge/services/pegboard/src/ops/actor/get.rsfor missing workflow data - Adds
Debugderive macro toWorkflowDatastruct for better debugging capabilities - Renames tracing span from 'client_fetch_remaining_actors_tx' to 'fetch_running_actors_tx' for clarity
- Updates formatting in multiple files for better code readability
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
d6f19c0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f71ed88d.rivet.pages.dev |
| Branch Preview URL: | https://06-02-fix-fix-pb-metrics-sta.rivet.pages.dev |
NathanFlurry
changed the base branch from
05-31-feat_guard_add_http_ping_endpoint_to_edge_api_hosts
to
graphite-base/2518
NathanFlurry
force-pushed
the
06-02-fix_fix_pb_metrics_standalone
branch
from
8985a25 to
46c1b87
Compare
NathanFlurry
changed the base branch from
graphite-base/2518
to
chore_disable_OTEL_by_default_in_guard_service
This was referenced Jun 2, 2025
MasterPtato
force-pushed
the
06-02-fix_fix_pb_metrics_standalone
branch
from
46c1b87 to
d6f19c0
Compare
Deploying rivet-studio with
|
| Latest commit: |
d6f19c0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6438f522.rivet-studio.pages.dev |
| Branch Preview URL: | https://06-02-fix-fix-pb-metrics-sta.rivet-studio.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
d6f19c0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1e990df6.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://06-02-fix-fix-pb-metrics-sta.rivet-hub-7jb.pages.dev |
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Jun 4, 2025
Closed
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes