fix(guard): dont route to installing api nodes #2564
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2025
Closed
Closed
This was referenced Jun 6, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implements server installation state tracking to prevent routing traffic to API nodes that haven't completed installation.
- Added
install_complete_tsfield to server queries inpackages/core/services/cluster/src/ops/server/{lost_list.rs,list.rs,get.rs} - Modified routing logic in
packages/edge/infra/guard/server/src/routing/api.rsto filter out servers without completed installation - Enhanced
Serverstruct inpackages/core/services/cluster/src/types.rswithinstall_complete_tsfield for state tracking - Improved reliability by preventing premature traffic routing to partially installed nodes
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
5409a33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b93e6292.rivet.pages.dev |
| Branch Preview URL: | https://06-06-fix-guard-dont-route-t.rivet.pages.dev |
Deploying rivet-studio with
|
| Latest commit: |
5409a33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c096d1db.rivet-studio.pages.dev |
| Branch Preview URL: | https://06-06-fix-guard-dont-route-t.rivet-studio.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
5409a33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://86e3e97d.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://06-06-fix-guard-dont-route-t.rivet-hub-7jb.pages.dev |
MasterPtato
force-pushed
the
06-06-fix_improve_error_handling_in_status_check
branch
from
36a1286 to
1d70f97
Compare
MasterPtato
force-pushed
the
06-06-fix_guard_dont_route_to_installing_api_nodes
branch
from
c562018 to
5409a33
Compare
This was referenced Jun 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
06-06-fix_guard_dont_route_to_installing_api_nodes
branch
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes