-
Notifications
You must be signed in to change notification settings - Fork 114
fix(pegboard): increase signal timeout, add check for actor exit #2538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying rivet-studio with
|
Latest commit: |
3b1c588
|
Status: | ✅ Deploy successful! |
Preview URL: | https://199c1912.rivet-studio.pages.dev |
Branch Preview URL: | https://06-04-fix-pegboard-increase.rivet-studio.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Enhances pegboard system's actor management and image prewarming with focus on signal handling and timeout improvements.
- Increased
STOP_PID_RETRIES
from 32 to 1024 inpackages/edge/infra/client/manager/src/actor/mod.rs
for longer actor stop timeout - Added actor exit check in signal handling to prevent unnecessary PID wait cycles
- Modified
prewarm_image
inpackages/edge/infra/client/manager/src/utils/mod.rs
to handle prewarming asynchronously withArc<Ctx>
- Reduced log spam by only showing progress every 10 retries during actor stop process
- Simplified image prewarming in
packages/edge/infra/client/manager/src/ctx.rs
by removing unnecessary task spawning
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
protocol::ToClient::PrewarmImage { | ||
image_id, | ||
image_artifact_url_stub, | ||
} => { | ||
let self2 = self.clone(); | ||
|
||
tokio::spawn(async move { | ||
utils::prewarm_image(&self2, image_id, &image_artifact_url_stub).await | ||
}); | ||
} | ||
} => utils::prewarm_image(&self, image_id, &image_artifact_url_stub), | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Consider adding .await to the utils::prewarm_image call since it's an async function
protocol::ToClient::PrewarmImage { | |
image_id, | |
image_artifact_url_stub, | |
} => { | |
let self2 = self.clone(); | |
tokio::spawn(async move { | |
utils::prewarm_image(&self2, image_id, &image_artifact_url_stub).await | |
}); | |
} | |
} => utils::prewarm_image(&self, image_id, &image_artifact_url_stub), | |
} | |
protocol::ToClient::PrewarmImage { | |
image_id, | |
image_artifact_url_stub, | |
} => utils::prewarm_image(&self, image_id, &image_artifact_url_stub).await?, |
Deploying rivet-hub with
|
Latest commit: |
3b1c588
|
Status: | ✅ Deploy successful! |
Preview URL: | https://afb57b1c.rivet-hub-7jb.pages.dev |
Branch Preview URL: | https://06-04-fix-pegboard-increase.rivet-hub-7jb.pages.dev |
Deploying rivet with
|
Latest commit: |
3b1c588
|
Status: | ✅ Deploy successful! |
Preview URL: | https://e6ea7fd5.rivet.pages.dev |
Branch Preview URL: | https://06-04-fix-pegboard-increase.rivet.pages.dev |
f9ef2e7
to
a52399a
Compare
4f69969
to
a38c8f3
Compare
a52399a
to
6f7c837
Compare
a38c8f3
to
100bf59
Compare
6f7c837
to
ec71a65
Compare
100bf59
to
5517494
Compare
ec71a65
to
bbbf37e
Compare
5517494
to
3b1c588
Compare
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Changes