Skip to content

Conversation

MasterPtato
Copy link
Contributor

Changes

@MasterPtato MasterPtato requested a review from NathanFlurry June 4, 2025 19:08
Copy link

cloudflare-workers-and-pages bot commented Jun 4, 2025

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b1c588
Status: ✅  Deploy successful!
Preview URL: https://199c1912.rivet-studio.pages.dev
Branch Preview URL: https://06-04-fix-pegboard-increase.rivet-studio.pages.dev

View logs

Copy link
Contributor Author

MasterPtato commented Jun 4, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhances pegboard system's actor management and image prewarming with focus on signal handling and timeout improvements.

  • Increased STOP_PID_RETRIES from 32 to 1024 in packages/edge/infra/client/manager/src/actor/mod.rs for longer actor stop timeout
  • Added actor exit check in signal handling to prevent unnecessary PID wait cycles
  • Modified prewarm_image in packages/edge/infra/client/manager/src/utils/mod.rs to handle prewarming asynchronously with Arc<Ctx>
  • Reduced log spam by only showing progress every 10 retries during actor stop process
  • Simplified image prewarming in packages/edge/infra/client/manager/src/ctx.rs by removing unnecessary task spawning

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 412 to 416
protocol::ToClient::PrewarmImage {
image_id,
image_artifact_url_stub,
} => {
let self2 = self.clone();

tokio::spawn(async move {
utils::prewarm_image(&self2, image_id, &image_artifact_url_stub).await
});
}
} => utils::prewarm_image(&self, image_id, &image_artifact_url_stub),
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Consider adding .await to the utils::prewarm_image call since it's an async function

Suggested change
protocol::ToClient::PrewarmImage {
image_id,
image_artifact_url_stub,
} => {
let self2 = self.clone();
tokio::spawn(async move {
utils::prewarm_image(&self2, image_id, &image_artifact_url_stub).await
});
}
} => utils::prewarm_image(&self, image_id, &image_artifact_url_stub),
}
protocol::ToClient::PrewarmImage {
image_id,
image_artifact_url_stub,
} => utils::prewarm_image(&self, image_id, &image_artifact_url_stub).await?,

Copy link

cloudflare-workers-and-pages bot commented Jun 4, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b1c588
Status: ✅  Deploy successful!
Preview URL: https://afb57b1c.rivet-hub-7jb.pages.dev
Branch Preview URL: https://06-04-fix-pegboard-increase.rivet-hub-7jb.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jun 4, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b1c588
Status: ✅  Deploy successful!
Preview URL: https://e6ea7fd5.rivet.pages.dev
Branch Preview URL: https://06-04-fix-pegboard-increase.rivet.pages.dev

View logs

@MasterPtato MasterPtato force-pushed the 06-04-fix_pegboard_revise_actor_rescheduling_algorithm_add_client_metrics branch from f9ef2e7 to a52399a Compare June 4, 2025 19:17
@MasterPtato MasterPtato force-pushed the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch from 4f69969 to a38c8f3 Compare June 4, 2025 19:17
@NathanFlurry NathanFlurry force-pushed the 06-04-fix_pegboard_revise_actor_rescheduling_algorithm_add_client_metrics branch from a52399a to 6f7c837 Compare June 5, 2025 00:58
@NathanFlurry NathanFlurry force-pushed the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch from a38c8f3 to 100bf59 Compare June 5, 2025 00:58
@MasterPtato MasterPtato force-pushed the 06-04-fix_pegboard_revise_actor_rescheduling_algorithm_add_client_metrics branch from 6f7c837 to ec71a65 Compare June 5, 2025 02:10
@MasterPtato MasterPtato force-pushed the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch from 100bf59 to 5517494 Compare June 5, 2025 02:10
Copy link
Contributor

graphite-app bot commented Jun 9, 2025

Merge activity

  • Jun 9, 4:46 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
  • Jun 9, 4:48 PM UTC: CI is running for this pull request on a draft pull request (#2574) due to your merge queue CI optimization settings.
  • Jun 9, 4:49 PM UTC: Merged by the Graphite merge queue via draft PR: #2574.

graphite-app bot pushed a commit that referenced this pull request Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Jun 9, 2025
@graphite-app graphite-app bot deleted the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch June 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant