fix: add vector http config to edge configs #2553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2025
This was referenced Jun 5, 2025
Closed
This was referenced Jun 5, 2025
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds vector_http configuration to edge configs and modifies workflow event handling for better data integrity and consistency.
- Added
vector_http: Some(VectorHttp::default())to server configurations in both/packages/core/services/cluster/src/workflows/server/install/install_scripts/components/rivet/guard.rsandworker.rs - Modified
event_namecolumn in/packages/common/chirp-workflow/core/src/db/fdb_sqlite_nats/sqlite/migrations/20250122212060_init.sqlto be nullable - Updated SQL query in
/packages/common/chirp-workflow/core/src/db/crdb_nats/debug.rsto properly retrieve removed event names - Added appropriate indexes and STRICT table constraints for better performance
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
bb905cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5297561c.rivet.pages.dev |
| Branch Preview URL: | https://06-05-fix-add-vector-http-co.rivet.pages.dev |
MasterPtato
force-pushed
the
06-05-fix_add_vector_http_config_to_edge_configs
branch
from
f942bc0 to
e1a8dda
Compare
This was referenced Jun 6, 2025
Deploying rivet-studio with
|
| Latest commit: |
bb905cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce3773e1.rivet-studio.pages.dev |
| Branch Preview URL: | https://06-05-fix-add-vector-http-co.rivet-studio.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
bb905cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8b92c1d5.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://06-05-fix-add-vector-http-co.rivet-hub-7jb.pages.dev |
MasterPtato
force-pushed
the
06-05-fix_add_vector_http_config_to_edge_configs
branch
from
e1a8dda to
bb905cd
Compare
This was referenced Jun 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
06-05-fix_add_vector_http_config_to_edge_configs
branch
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes