fix: improve error handling in status check #2563
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2025
Closed
This was referenced Jun 6, 2025
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced error handling and observability in the actor status check implementation within packages/core/api/status/src/route/actor.rs.
- Added structured error handling for actor creation/destruction with specific HTTP status code handling
- Added request body extraction into separate variable for better code clarity
- Improved tracing spans by including
base_pathin debug information - Enhanced error messages with
ray_idfor better request traceability - Refactored error handling without modifying core business logic
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+226
to
+229
| bail_with!( | ||
| INTERNAL_STATUS_CHECK_FAILED, | ||
| error = format!("{}: {} (ray_id {})", body.code, body.message, body.ray_id) | ||
| ); |
There was a problem hiding this comment.
style: Consider wrapping this error handling in a helper function since it's repeated in the actor destroy code
Deploying rivet with
|
| Latest commit: |
1d70f97
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://846a0857.rivet.pages.dev |
| Branch Preview URL: | https://06-06-fix-improve-error-hand.rivet.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
1d70f97
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19a14910.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://06-06-fix-improve-error-hand.rivet-hub-7jb.pages.dev |
Deploying rivet-studio with
|
| Latest commit: |
1d70f97
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://84990049.rivet-studio.pages.dev |
| Branch Preview URL: | https://06-06-fix-improve-error-hand.rivet-studio.pages.dev |
MasterPtato
force-pushed
the
06-05-fix_add_vector_http_config_to_edge_configs
branch
from
e1a8dda to
bb905cd
Compare
MasterPtato
force-pushed
the
06-06-fix_improve_error_handling_in_status_check
branch
from
36a1286 to
1d70f97
Compare
This was referenced Jun 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
06-06-fix_improve_error_handling_in_status_check
branch
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes