fix(cluster): fix scaling logic and dedup metrics #2566
Closed
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2025
Closed
This was referenced Jun 6, 2025
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Major overhaul of resource metrics collection and server filtering logic in the cluster management system.
- Modified Prometheus query in
packages/core/services/cluster/src/ops/datacenter/topology_get/pegboard.rsto handle raw metrics directly instead of using 15-minute time windows, improving data accuracy - Added deduplication logic based on timestamp comparison to ensure latest metrics are used
- Removed
taint_ts IS NULLfilter inpackages/core/services/cluster/src/ops/datacenter/topology_get/mod.rs, allowing tainted servers to be included in topology calculations - Fixed incorrect metric unit comments in pegboard client usage implementation
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
4da1c2e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8973d268.rivet.pages.dev |
| Branch Preview URL: | https://06-06-fix-cluster-fix-scalin.rivet.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
4da1c2e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a173ee30.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://06-06-fix-cluster-fix-scalin.rivet-hub-7jb.pages.dev |
Deploying rivet-studio with
|
| Latest commit: |
4da1c2e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://917c207d.rivet-studio.pages.dev |
| Branch Preview URL: | https://06-06-fix-cluster-fix-scalin.rivet-studio.pages.dev |
MasterPtato
force-pushed
the
06-06-feat_pegboard_add_draining_state_to_alloc_metrics
branch
from
f5fcd8b to
5c607af
Compare
MasterPtato
force-pushed
the
06-06-fix_cluster_fix_scaling_logic_and_dedup_metrics
branch
from
0be6e64 to
c1c5ebd
Compare
MasterPtato
force-pushed
the
06-06-fix_cluster_fix_scaling_logic_and_dedup_metrics
branch
from
c1c5ebd to
4da1c2e
Compare
This was referenced Jun 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
06-06-fix_cluster_fix_scaling_logic_and_dedup_metrics
branch
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes