-
Notifications
You must be signed in to change notification settings - Fork 114
fix: dont include installing servers in service discovery #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dont include installing servers in service discovery #2569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Enhances service discovery reliability by filtering out installing servers in datacenters.rs
. This prevents premature inclusion of servers that haven't completed installation in the service discovery system.
- Modified
packages/core/api/provision/src/route/datacenters.rs
to exclude servers whereinstall_complete_ts
is None from service discovery results
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
Latest commit: |
1336a33
|
Status: | ✅ Deploy successful! |
Preview URL: | https://b2332e38.rivet.pages.dev |
Branch Preview URL: | https://graphite-base-2570.rivet.pages.dev |
11a498b
to
1336a33
Compare
b59017e
to
9b454d7
Compare
Deploying rivet-studio with
|
Latest commit: |
1336a33
|
Status: | ✅ Deploy successful! |
Preview URL: | https://41b481ea.rivet-studio.pages.dev |
Branch Preview URL: | https://graphite-base-2570.rivet-studio.pages.dev |
Deploying rivet-hub with
|
Latest commit: |
1336a33
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f6a09f6d.rivet-hub-7jb.pages.dev |
Branch Preview URL: | https://graphite-base-2570.rivet-hub-7jb.pages.dev |
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Changes