Skip to content

Conversation

MasterPtato
Copy link
Contributor

Changes

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhances service discovery reliability by filtering out installing servers in datacenters.rs. This prevents premature inclusion of servers that haven't completed installation in the service discovery system.

  • Modified packages/core/api/provision/src/route/datacenters.rs to exclude servers where install_complete_ts is None from service discovery results

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor Author

MasterPtato commented Jun 6, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

cloudflare-workers-and-pages bot commented Jun 6, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1336a33
Status: ✅  Deploy successful!
Preview URL: https://b2332e38.rivet.pages.dev
Branch Preview URL: https://graphite-base-2570.rivet.pages.dev

View logs

@graphite-app graphite-app bot changed the base branch from 06-06-fix_pegboard_fix_allocation_metrics to graphite-base/2569 June 9, 2025 16:49
@MasterPtato MasterPtato force-pushed the 06-06-fix_dont_include_installing_servers_in_service_discovery branch from 11a498b to 1336a33 Compare June 9, 2025 16:59
@MasterPtato MasterPtato force-pushed the graphite-base/2569 branch from b59017e to 9b454d7 Compare June 9, 2025 16:59
Copy link

cloudflare-workers-and-pages bot commented Jun 9, 2025

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1336a33
Status: ✅  Deploy successful!
Preview URL: https://41b481ea.rivet-studio.pages.dev
Branch Preview URL: https://graphite-base-2570.rivet-studio.pages.dev

View logs

@MasterPtato MasterPtato changed the base branch from graphite-base/2569 to main June 9, 2025 16:59
Copy link

cloudflare-workers-and-pages bot commented Jun 9, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1336a33
Status: ✅  Deploy successful!
Preview URL: https://f6a09f6d.rivet-hub-7jb.pages.dev
Branch Preview URL: https://graphite-base-2570.rivet-hub-7jb.pages.dev

View logs

Copy link
Contributor

graphite-app bot commented Jun 12, 2025

Merge activity

  • Jun 12, 10:30 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
  • Jun 12, 10:31 PM UTC: CI is running for this pull request on a draft pull request (#2588) due to your merge queue CI optimization settings.
  • Jun 12, 10:32 PM UTC: Merged by the Graphite merge queue via draft PR: #2588.

graphite-app bot pushed a commit that referenced this pull request Jun 12, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Jun 12, 2025
@graphite-app graphite-app bot deleted the 06-06-fix_dont_include_installing_servers_in_service_discovery branch June 12, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant