feat(pegboard): add draining state to alloc metrics #2565
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2025
Closed
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced pegboard service metrics by adding client state tracking to resource allocation measurements, enabling better visibility into resource usage across different client lifecycle states.
- Added 'state' label to resource metrics in
packages/edge/services/pegboard/src/metrics.rsfor both allocated and total CPU/memory usage - Improved code readability in
packages/edge/services/pegboard/src/workflows/actor/analytics.rsby splitting environment variable byte calculation logic
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet-studio with
|
| Latest commit: |
5c607af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88e9dc54.rivet-studio.pages.dev |
| Branch Preview URL: | https://06-06-feat-pegboard-add-drai.rivet-studio.pages.dev |
Deploying rivet with
|
| Latest commit: |
5c607af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ed77dc28.rivet.pages.dev |
| Branch Preview URL: | https://06-06-feat-pegboard-add-drai.rivet.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
5c607af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab9fc6b0.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://06-06-feat-pegboard-add-drai.rivet-hub-7jb.pages.dev |
MasterPtato
force-pushed
the
06-06-feat_pegboard_add_draining_state_to_alloc_metrics
branch
from
f5fcd8b to
5c607af
Compare
MasterPtato
force-pushed
the
06-06-fix_guard_dont_route_to_installing_api_nodes
branch
from
c562018 to
5409a33
Compare
This was referenced Jun 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
06-06-feat_pegboard_add_draining_state_to_alloc_metrics
branch
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes