-
Notifications
You must be signed in to change notification settings - Fork 122
refactor: replace unsafe File::from_raw_fd with safe File::from #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace unsafe File::from_raw_fd with safe File::from #2479
Conversation
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR improves safety by replacing unsafe std::fs::File::from_raw_fd
calls with safe std::fs::File::from
in packages/edge/infra/client/isolate-v8-runner/src/isolate.rs
when handling pipe file descriptors.
- Replaces unsafe
File::from_raw_fd
with safeFile::from
for stdout and stderr pipe handling - Maintains identical functionality while eliminating unsafe code blocks
- Change is focused on pipe file descriptor management in the isolate runner
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
bb17add
to
6d7e7f9
Compare
Deploying rivet-studio with
|
Latest commit: |
ac3d4cd
|
Status: | ✅ Deploy successful! |
Preview URL: | https://27d1f46c.rivet-studio.pages.dev |
Branch Preview URL: | https://refactor-replace-unsafe-file.rivet-studio.pages.dev |
Deploying rivet-hub with
|
Latest commit: |
ac3d4cd
|
Status: | ✅ Deploy successful! |
Preview URL: | https://c3929cd9.rivet-hub-7jb.pages.dev |
Branch Preview URL: | https://refactor-replace-unsafe-file.rivet-hub-7jb.pages.dev |
Deploying rivet with
|
Latest commit: |
ac3d4cd
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d7675ba3.rivet.pages.dev |
Branch Preview URL: | https://refactor-replace-unsafe-file.rivet.pages.dev |
6d7e7f9
to
f093d49
Compare
f093d49
to
ac3d4cd
Compare
ac3d4cd
to
e35c673
Compare
e35c673
to
ac3d4cd
Compare
Merge activity
|
Changes