Skip to content

Conversation

NathanFlurry
Copy link
Member

Changes

Copy link
Member Author

NathanFlurry commented May 27, 2025


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR improves safety by replacing unsafe std::fs::File::from_raw_fd calls with safe std::fs::File::from in packages/edge/infra/client/isolate-v8-runner/src/isolate.rs when handling pipe file descriptors.

  • Replaces unsafe File::from_raw_fd with safe File::from for stdout and stderr pipe handling
  • Maintains identical functionality while eliminating unsafe code blocks
  • Change is focused on pipe file descriptor management in the isolate runner

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@NathanFlurry NathanFlurry force-pushed the refactor_replace_unsafe_File_from_raw_fd_with_safe_File_from branch from bb17add to 6d7e7f9 Compare May 28, 2025 23:18
Copy link

cloudflare-workers-and-pages bot commented May 28, 2025

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac3d4cd
Status: ✅  Deploy successful!
Preview URL: https://27d1f46c.rivet-studio.pages.dev
Branch Preview URL: https://refactor-replace-unsafe-file.rivet-studio.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented May 28, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac3d4cd
Status: ✅  Deploy successful!
Preview URL: https://c3929cd9.rivet-hub-7jb.pages.dev
Branch Preview URL: https://refactor-replace-unsafe-file.rivet-hub-7jb.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented May 28, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac3d4cd
Status: ✅  Deploy successful!
Preview URL: https://d7675ba3.rivet.pages.dev
Branch Preview URL: https://refactor-replace-unsafe-file.rivet.pages.dev

View logs

Copy link
Contributor

graphite-app bot commented Jun 3, 2025

Merge activity

  • Jun 3, 7:01 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jun 3, 7:02 AM UTC: CI is running for this pull request on a draft pull request (#2528) due to your merge queue CI optimization settings.
  • Jun 3, 7:03 AM UTC: Merged by the Graphite merge queue via draft PR: #2528.

@graphite-app graphite-app bot closed this Jun 3, 2025
@graphite-app graphite-app bot deleted the refactor_replace_unsafe_File_from_raw_fd_with_safe_File_from branch June 3, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant